diff --git a/modules/p2/ding_list/include/functions.inc b/modules/p2/ding_list/include/functions.inc index a5c98b0da2..a4a72f48c2 100644 --- a/modules/p2/ding_list/include/functions.inc +++ b/modules/p2/ding_list/include/functions.inc @@ -657,7 +657,6 @@ function ding_list_add_permission($list, $permission, $account = NULL) { )); $id = $account->uid; - // TODO I suggest replacing module_exists with ding_provider_implements. if (ding_provider_implements('openlist', 'user_identifier')) { $id = ding_provider_invoke('openlist', 'user_identifier', $account); } diff --git a/modules/p2/ting_openlist/ting_openlist.module b/modules/p2/ting_openlist/ting_openlist.module index 5f06c7afb4..1b3cada873 100644 --- a/modules/p2/ting_openlist/ting_openlist.module +++ b/modules/p2/ting_openlist/ting_openlist.module @@ -35,8 +35,7 @@ function ting_openlist_ding_provider() { return array( 'title' => 'Ting Openlist provider', - // Notice we set the file path in hook_menu_alter() - 'file' => 'ting_openlist.admin.inc', + 'file' => drupal_get_path('module', 'ting_openlist') . '/ting_openlist.admin.inc', 'settings' => 'ting_openlist_settings_form', 'provides' => array( 'openlist' => array( @@ -47,22 +46,6 @@ function ting_openlist_ding_provider() { ); } -/** - * Implements hook_menu_alter(). - * - * This fixes the ding_provider menu, without the need to do any changes - * to the core module (although the ding_provider module should get fixed) - * - * TODO Why is this needed? Could we fix this in ding_provider instead? - * - * TODO-REPLY ding_provider needs to implement the file path option in the - * hook_menu. If file path is not supplied it looks for file in - * the ding_provider folder. - */ -function ting_openlist_menu_alter(&$items) { - $items['admin/config/ding/provider/ting_openlist']['file path'] = drupal_get_path('module', 'ting_openlist'); -} - /** * Implements hook_menu(). */ diff --git a/modules/p2/ting_token/ting_token.module b/modules/p2/ting_token/ting_token.module index ff6b459dda..3761b774e2 100644 --- a/modules/p2/ting_token/ting_token.module +++ b/modules/p2/ting_token/ting_token.module @@ -12,8 +12,7 @@ function ting_token_preprocess_page(&$variables) { drupal_add_library('system', 'drupal.ajax'); drupal_add_library('system', 'drupal.form'); drupal_add_library('system', 'jquery.form'); - // TODO Typo? - drupal_add_library('system', 'druapl.progress'); + drupal_add_library('system', 'drupal.progress'); drupal_add_library('system', 'drupal.textarea'); drupal_add_js( array(