Add defensive coding to prevent warnings if module is in database but not the file system

[laryn]

Defensive coding could be added to prevent messy output like this:

⚠️ Warning: Undefined array key "xmlsitemap"
in enable_bee_callback() (line 217 of /usr/local/bin/bee/commands/projects.bee.inc).

⚠️ Warning: Attempt to read property "info" on null
in enable_bee_callback() (line 218 of /usr/local/bin/bee/commands/projects.bee.inc).

⚠️ Warning: Trying to access array offset on null
in enable_bee_callback() (line 218 of /usr/local/bin/bee/commands/projects.bee.inc).

⚠️ Warning: Attempt to read property "status" on null
in enable_bee_callback() (line 221 of /usr/local/bin/bee/commands/projects.bee.inc).

⚠️ Warning: Attempt to read property "name" on null
in enable_bee_callback() (line 227 of /usr/local/bin/bee/commands/projects.bee.inc).

⚠️ Warning: array_flip(): Can only flip string and integer values, entry skipped
in bee_get_required_modules() (line 68 of /usr/local/bin/bee/includes/dependencies.inc).

✘ The '' module could not be enabled due to missing dependencies.

In this case I tried to enable a module that was not present in the filesystem.

[yorkshire-pudding]

Hi @laryn . Could you check your bee version using bee version as I can't reproduce this.

I tried to enable a module I knew wasn't on the site:

lando bee en abjs

and got this.

 ✘  Project 'abjs' could not be found.

Or perhaps this is happening for just one project?

[laryn]

Sure, I'll check. I thought I had the latest but maybe not!

EDIT:

🐝 Bee for Backdrop CMS
Version: 1.x-1.2.x-dev - 2025-08-30
Latest Release: 1.x-1.1.0

[laryn]

@yorkshire-pudding It looks like I'm falling through this code:

bee/commands/projects.bee.inc

Lines 207 to 212 in c731638

	if (!$type = projects_bee_get_type($project)) {
	bee_message(bt("Project '!name' could not be found.", array(
	'!name' => $project,
	)), 'error');
	continue;
	}

Maybe different versions of PHP?

I'll test with more explicit brackets like this:
(!($type = projects_bee_get_type($project)))

[laryn]

@yorkshire-pudding In my testing, that does seem to fix it. (This was tested on PHP 8.3.) PR submitted for your consideration.

[indigoxela]

Hm, I'm also having trouble to reproduce it on PHP 8.3. I'm on the latest git version of bee and all I see is the regular error message. Testing on a site with Backdrop 1.33.1.

# bee dl foobarbaz

 ✘  The 'foobarbaz' project repository could not be found. Please check your spelling and try again.

# bee en barbaz

 ✘  Project 'barbaz' could not be found.

Could the warnings you see be caused by a module @laryn?

[yorkshire-pudding]

I've just tested on latest bee with dev version of Backdrop (i.e. in the Bee dev environment) on PHP 8.3.28 and I still get:

$ lando bee en abjs

 ✘  Project 'abjs' could not be found.

[yorkshire-pudding]

Digging deeper @laryn

The message you get is slightly different at the end:

✘ The '' module could not be enabled due to missing dependencies.

Now, bee will download dependencies when you download a project, so perhaps there is some different set of conditions that have caused this which is why we can't reproduce. That doesn't mean we shouldn't do more defensive coding, but we need to get so we can reproduce the conditions.

So, what is the project you tried to enable?

[indigoxela]

Aha! Getting closer...

A dummy module with a dummy dependency on something. Info file:

type = module
name = Foobar
descriptioon = Testing bee stuff
backdrop = 1.x
dependencies[] = barbaz

Then:

# bee en foobar

 ⚠️  Warning: foreach() argument must be of type array|object, false given
in enable_bee_callback() (line 229 of /usr/local/bin/bee_git/commands/projects.bee.inc).


 ✘  The 'Foobar' module could not be enabled due to missing dependencies.

So, that's the trick to reproduce (sort of). Slightly different, but similar.

[laryn]

Ah, I think I may have tracked down this weird scenario. Try where a module is enabled in the system table, but not present in the filesystem. I think one case where this may happen is during D7 upgrades where a module was not deactivated on the Drupal side but may not be present in the Backdrop system for a variety of reasons.

[yorkshire-pudding]

Hi @laryn
I managed to reproduce the warnings by:

$ lando bee dl abjs

 ✔  'abjs' (1.x-1.1.0, published at 2026-01-29T13:51:38Z) was downloaded into '/app/backdrop/modules/abjs'. For more information see https://github.com/backdrop-contrib/abjs/releases/tag/1.x-1.1.0

$ lando bee en abjs

 ✔  The 'A/B Test JS' module was enabled.

$ lando bee dis abjs

 ✔  The 'A/B Test JS' module was disabled.

$ rm -rf modules/abjs
$ lando bee en abjs

 ⚠️  Warning: Undefined array key "abjs"
in enable_bee_callback() (line 217 of /app/commands/projects.bee.inc).


 ⚠️  Warning: Attempt to read property "info" on null
in enable_bee_callback() (line 218 of /app/commands/projects.bee.inc).


 ⚠️  Warning: Trying to access array offset on null
in enable_bee_callback() (line 218 of /app/commands/projects.bee.inc).


 ⚠️  Warning: Attempt to read property "status" on null
in enable_bee_callback() (line 221 of /app/commands/projects.bee.inc).


 ⚠️  Warning: Attempt to read property "name" on null
in enable_bee_callback() (line 227 of /app/commands/projects.bee.inc).


 ⚠️  Warning: array_flip(): Can only flip string and integer values, entry skipped
in bee_get_required_modules() (line 68 of /app/includes/dependencies.inc).


 ✘  The '' module could not be enabled due to missing dependencies.

However, that patch does not affect the result; I still get the same warnings.
Given the information is in the database then I don't think it fails at that line (at least not for this scenario), but fails because the information isn't in system_rebuild_module_data() (for modules)

Perhaps the defensive code needs to be in the switch statement and check that the module/theme (layout templates won't be in the database) is in the relevant array before continuing.

[laryn]

Yes, I retract my earlier "fix" -- I think I changed a few things that didn't seem relevant but must have been, since I wasn't sure exactly where the error was coming from.