Merge pull request microsoft#4 from majnemer/volatile-deref

russellhadley · russellhadley · commit 2fc7859d212d · 2015-11-16T10:21:45.000-08:00
Dereferencing null is UB.
diff --git a/eh/terminate.cpp b/eh/terminate.cpp
@@ -30,7 +30,7 @@ class C
         if (FGenSEHException)
         {
             printf("generating access violation (SEH)\n");
-            *(char*)(0) = 0; // Uh, EHa, don't you think?
+            *(volatile char*)(0) = 0; // Uh, EHa, don't you think?
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class C`
`30`	`30`	`if (FGenSEHException)`
`31`	`31`	`{`
`32`	`32`	`printf("generating access violation (SEH)\n");`
`33`		`- (char)(0) = 0; // Uh, EHa, don't you think?`
	`33`	`+ (volatile char)(0) = 0; // Uh, EHa, don't you think?`
`34`	`34`	`}`
`35`	`35`	`else`
`36`	`36`	`{`