Transaction: reuse address

[turunut]

Hi again :)
I have been playing with the wallet and I have detected a possible problem. I have done a transaction from an address with 2i, but I sent only 1i. I have observed that the remaining iota was send back to the original address. Is not this a problem? As far as I know ones you have send iotas from and address you should not use it again.
I'm wrong?

Thank you very much

[bahamapascal]

Hey Turuntu,
Yes that is correct, this should not happen! Can you give me the bundle ID perhaps?
Normaly the CL-wallet will always send the remaining to the deposit address. Maybe, if you sent Iotas to the deposit address the CL-Wallet ave you and then don't make an account info call (which is when a new deposit address is generated) before sending again, then maybe this can happen. I am not sure at the moment if a new deposit address is generated when making a send transfer request and the old deposit address is already used.

[bahamapascal]

Think I found the bug. Just took a look at the code. And there is one case where this can happen. If you have a new account, deposit to the deposit address and then make a transfer before caling account info.
Whta is missing is the update_fal_balance() call on line #440 (should be called before l_index = fal_balance[0]["l_index"] )

Thanks for reporting this bug!

[turunut]

Nice!
Here is the trasaction:
https://thetangle.org/bundle/DDGEBGP9DCBSX9BOOIQOGJVJWDRCAEUILRJYIQDCBJXUKRFVYZWVCP9QWFUH9GIZ9PKXGISAVGEFRHNGW
And yes, it was a new account using the first address.

I have some other questions but they are not issues... about the wallet and some features. Where could I send you a message? My email is in my profile in case you want to send me a PM.

[bahamapascal]

Hey sorry I didn't get back to you earlier! Was distracted with the holly days and family
I have integraded the fix here: 244ad43
It will get added to the dev/main branch with the net big update. Currently we are refactoring the code to classes, for better performance and maintainability.

Regarding PM, I didn't find your e-mail address. You can contact me on slack (@bahamapascal) or send me a mail at tomatengot@gmail.com

[turunut]

Perfect!

I will send you an email then ;)