Add tests for user reactivation feature

Author: dilberryhoundog

test/controllers/join_codes_controller_test.rb

@@ -55,6 +55,27 @@ class JoinCodesControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to landing_url(script_name: @account.slug)
   end
 
+  test "create for existing identity with deactivated user" do
+    identity = identities(:kevin)
+    user = users(:kevin)
+
+    sign_in_as :kevin
+
+    assert user.setup?, "Kevin should be setup for this test"
+    user.deactivate
+
+    assert_not user.reload.active?, "user should be inactive after deactivation"
+    assert_equal identity.id, user.identity_id, "identity link should be preserved after deactivation"
+
+    assert_no_difference -> { User.count } do
+      post join_path(code: @join_code.code, script_name: @account.slug), params: { email_address: identity.email_address }
+    end
+
+    user.reload
+    assert user.active?, "user should be reactivated after joining"
+    assert_redirected_to landing_url(script_name: @account.slug)
+  end
+
   test "create for signed-in identity without a user in the account redirects to verification" do
     identity = identities(:mike)
     sign_in_as :mike

test/models/identity/joinable_test.rb

@@ -34,4 +34,26 @@ class Identity::JoinableTest < ActiveSupport::TestCase
       assert_not result, "join should return false when user already exists"
     end
   end
+
+  test "join reactivates a deactivated user" do
+    identity = identities(:kevin)
+    account = accounts("37s")
+    user = users(:kevin)
+
+    user.stubs(:close_remote_connections)
+    user.deactivate
+
+    assert_not user.reload.active?, "user should be inactive after deactivation"
+    assert_empty user.accesses, "user should have no accesses after deactivation"
+    assert_equal identity.id, user.identity_id, "identity link should be preserved after deactivation"
+
+    assert_no_difference -> { User.count } do
+      result = identity.join(account)
+      assert_not result, "join should return false for reactivation"
+    end
+
+    user.reload
+    assert user.active?, "user should be active after reactivation"
+    assert user.accesses.any?, "user should have accesses restored after reactivation"
+  end
 end