Skip to content

Comments

Decorator selection#727

Open
samuelpecher wants to merge 3 commits intoprovisional-paragraphfrom
decorator-selection
Open

Decorator selection#727
samuelpecher wants to merge 3 commits intoprovisional-paragraphfrom
decorator-selection

Conversation

@samuelpecher
Copy link
Collaborator

@samuelpecher samuelpecher commented Feb 10, 2026 •
edited
Loading

Rework DecoratorNode selection by handling CLICK_COMMAND rather than manually attaching a click handler on the generated DOM with an internal events system.

Allows removal of the lexxy:internal:select-node event handling.

cc @packagethief

@samuelpecher samuelpecher force-pushed the provisional-paragraph branch 2 times, most recently from 0f988d7 to 9f89ff5 Compare February 11, 2026 12:17
@samuelpecher samuelpecher force-pushed the decorator-selection branch 2 times, most recently from 4ce151b to db2bcbe Compare February 11, 2026 12:54
@samuelpecher
Use click command handler for DecoratorNode selection
ca316a4 
Using $getNearestNodeFromDOMNode, the CLICK_COMMAND handler can find the
appropriate node and pass the `select` message to the node. We can now
encapsulate the desired behavior in the node directly and inherit the
command's implied `editor.update()` context.
@samuelpecher
Remove wait_for_node_selection test helper
f28b9fb 
Since node selection no longer relies on events, no need to wait fo the
event loop
@samuelpecher
Build assets
4588c13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samuelpecher