Skip to content

create_jvm_test_suite: allow multiple suites to use same test source #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −1
Closed

create_jvm_test_suite: allow multiple suites to use same test source #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/private/create_jvm_test_suite.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def create_jvm_test_suite(

for src in test_srcs:
suffix = src.rfind(".")
test_name = src[:suffix]
test_name = "%s-%s" % (name, src[:suffix])
Copy link

@gemini-code-assist gemini-code-assist bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The src variable can contain path separators (e.g., com/foo/MyTest.java) if the test sources are organized in subdirectories. The current construction of test_name does not account for this, which will result in an invalid target name like my_suite-com/foo/MyTest because target names cannot contain /.

To fix this, you should replace path separators with a valid character like -. This will ensure that generated test names are always valid Bazel target names.

Suggested change
test_name = "%s-%s" % (name, src[:suffix])
test_name = "%s-%s" % (name, src[:suffix].replace("/", "-"))

Copy link
Author

@dmivankov dmivankov Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That aspect doesn't change in this PR, will leave it to maintainers to decide what to do

test_class = get_class_name(package, src, package_prefixes)

test_name = define_test(
Expand Down