Update the Gazelle Java plugin to handle java_maven_install_file directives in nested directories
#384
+942
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
maven.Resolverfor each instance ofjava_maven_install_fileand use that resolver for all files under that directory. There aren't any changes to the default behavior; but nestedjava_maven_install_filedeclarations will now work as expected.Background
The Gazelle plugin parses
java_maven_install_filedirectives in nested directories but doesn't use the file when resolving dependencies. This is a problem for projects that use different Maven repositories for different parts of the repository. The top-levelmaven_install.jsonfile may have incomplete or extra dependencies than the one configured for the lower level directory.Testing
The unit tests have been updated to reflect the new interface. Integration tests have been added to confirm the updated behavior for an invalid
maven_install.jsonfile.