use a perl script for mixed_language_module_map_extender #1624
+91
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alex-ameen
force-pushed
the
aameen/optimize-mmext
branch
2 times, most recently
from
4808667 to
732aaa3
Compare
alex-ameen
force-pushed
the
aameen/optimize-mmext
branch
from
46df215 to
245d4c0
Compare
alex-ameen
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes existing
mixed_language_module_map_extenderto avoid repeatedly spinning upperlruntimes by simply making it aperlscript.We experienced performance issues with this script in our repos and are hoping this will speed things up.
Bazel profiles showed a small improvement on ~2,000 invocations of the tool, 258s to 230s. Nothing too dramatic, but a nice ~10% improvement.