-
Notifications
You must be signed in to change notification settings - Fork 18
Bug in Prime Tests, gcd != 1 #31
Copy link
Copy link
Open
Description
There is a bug in some prime tests.
This lines are wrong, it fails to detect if gcdTest.dataLength > 1
if (gcdTest.dataLength == 1 && gcdTest.data[0] != 1)
it should be
if (gcdTest.dataLength > 1 || gcdTest.dataLength == 1 && gcdTest.data[0] != 1)
(I replaced all this check with IsNegative, IsOne, IsOdd, etc.
Sad that this code is not supposed anymore, it is the best c# code I know)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels