From 092fc3dc577ed3e6ea2753c7de72b22739c7fc77 Mon Sep 17 00:00:00 2001
From: bcgov-brwang <87880048+bcgov-brwang@users.noreply.github.com>
Date: Thu, 15 Jan 2026 09:16:57 -0800
Subject: [PATCH 1/2] DBC22-5275: made sure the useEffect can be fired when url
path changed
---
src/frontend/src/Components/routing/DistanceLabels.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/frontend/src/Components/routing/DistanceLabels.js b/src/frontend/src/Components/routing/DistanceLabels.js
index 57f1f23b5..fd2211f91 100644
--- a/src/frontend/src/Components/routing/DistanceLabels.js
+++ b/src/frontend/src/Components/routing/DistanceLabels.js
@@ -40,7 +40,7 @@ export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail
addDistanceOverlay();
updateRouteDisplay(selectedRoute);
- }, [selectedRoute]);
+ }, [selectedRoute, location.search]);
/* Rendering */
// Threshold of 500 meters in distance by default
From 5dc15f05b86c6b09adbfc10377e95eff43b05660 Mon Sep 17 00:00:00 2001
From: bcgov-brwang <87880048+bcgov-brwang@users.noreply.github.com>
Date: Mon, 2 Feb 2026 14:39:52 -0800
Subject: [PATCH 2/2] DBC22-5275: used mapRendered instead of location.search
to update distance label
---
src/frontend/src/Components/map/Map.js | 2 +-
src/frontend/src/Components/routing/DistanceLabels.js | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/frontend/src/Components/map/Map.js b/src/frontend/src/Components/map/Map.js
index f484a9df5..91268d35d 100644
--- a/src/frontend/src/Components/map/Map.js
+++ b/src/frontend/src/Components/map/Map.js
@@ -959,7 +959,7 @@ export default function DriveBCMap(props) {
}
{searchedRoutes && searchedRoutes.length > 0 &&
-
+
}
{!!openPanel && largeScreen &&
diff --git a/src/frontend/src/Components/routing/DistanceLabels.js b/src/frontend/src/Components/routing/DistanceLabels.js
index 2418cd682..2cd5d2cf4 100644
--- a/src/frontend/src/Components/routing/DistanceLabels.js
+++ b/src/frontend/src/Components/routing/DistanceLabels.js
@@ -20,7 +20,7 @@ import distance from "@turf/distance";
// Styling
import './DistanceLabels.scss';
-export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail }) {
+export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail, mapRendered }) {
/* initialization */
// Redux
@@ -36,13 +36,13 @@ export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail
/* useEffect hooks */
useEffect(() => {
- if (!mapRef || !mapRef.current) {
+ if (!mapRef || !mapRef.current || !mapRendered) {
return;
}
addDistanceOverlay();
updateRouteDisplay(selectedRoute);
- }, [selectedRoute, location.search]);
+ }, [selectedRoute, mapRendered]);
/* Rendering */
// Threshold of 500 meters in distance by default