Skip to content

Fix ZAP scan security vulnerabilities with proper CSP and security headers #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: develop
Choose a base branch
from
+102 −2
Draft

Fix ZAP scan security vulnerabilities with proper CSP and security headers #3677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3660a81
Initial plan
Copilot Sep 19, 2025
4ac2eb5
Add security headers and explicit robots.txt/sitemap.xml endpoints
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion services/core-web/runner/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,22 @@ app.use(
? {
directives: CONTENT_SECURITY_POLICY,
}
: false,
: {
directives: {
defaultSrc: ["'self'"],
scriptSrc: ["'self'", "'unsafe-inline'"], // Note: unsafe-inline should be removed when proper nonces are implemented
styleSrc: ["'self'", "'unsafe-inline'"], // Note: unsafe-inline should be removed when proper nonces are implemented
imgSrc: ["'self'", "data:", "https:"],
connectSrc: ["'self'"],
fontSrc: ["'self'"],
objectSrc: ["'none'"],
mediaSrc: ["'self'"],
frameSrc: ["'none'"],
},
},
crossOriginEmbedderPolicy: { policy: "require-corp" },
crossOriginOpenerPolicy: { policy: "same-origin" },
crossOriginResourcePolicy: { policy: "same-origin" },
})
);

Expand Down Expand Up @@ -100,10 +115,45 @@ app.get(`/version`, (req, res) => {
});
});

// Explicit robots.txt endpoint with proper security headers
app.get('/robots.txt', (req, res) => {
res.setHeader('Content-Type', 'text/plain');
res.setHeader('Cache-Control', 'public, max-age=86400');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.send('User-agent: *\nDisallow: /');
});

// Explicit sitemap.xml endpoint with proper security headers
app.get('/sitemap.xml', (req, res) => {
res.setHeader('Content-Type', 'application/xml');
res.setHeader('Cache-Control', 'public, max-age=86400');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.send('<?xml version="1.0" encoding="UTF-8"?>\n<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">\n</urlset>');
});

// Handle trailing slash redirects for robots.txt and sitemap.xml
app.get('/robots.txt/', (req, res) => {
res.redirect(301, '/robots.txt');
});

app.get('/sitemap.xml/', (req, res) => {
res.redirect(301, '/sitemap.xml');
});

app.use((req, res, next) => {
if (PERMISSIONS_POLICY) {
res.setHeader("Permissions-Policy", PERMISSIONS_POLICY);
}

// Additional security headers to address ZAP scan issues
res.setHeader('Cross-Origin-Embedder-Policy', 'require-corp');
res.setHeader('Cross-Origin-Opener-Policy', 'same-origin');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.setHeader('Referrer-Policy', 'strict-origin-when-cross-origin');

next();
});

Expand Down
52 changes: 51 additions & 1 deletion services/minespace-web/runner/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,22 @@ app.use(
? {
directives: CONTENT_SECURITY_POLICY,
}
: false,
: {
directives: {
defaultSrc: ["'self'"],
scriptSrc: ["'self'", "'unsafe-inline'"], // Note: unsafe-inline should be removed when proper nonces are implemented
styleSrc: ["'self'", "'unsafe-inline'"], // Note: unsafe-inline should be removed when proper nonces are implemented
imgSrc: ["'self'", "data:", "https:"],
connectSrc: ["'self'"],
fontSrc: ["'self'"],
objectSrc: ["'none'"],
mediaSrc: ["'self'"],
frameSrc: ["'none'"],
},
},
crossOriginEmbedderPolicy: { policy: "require-corp" },
crossOriginOpenerPolicy: { policy: "same-origin" },
crossOriginResourcePolicy: { policy: "same-origin" },
})
);

Expand Down Expand Up @@ -89,10 +104,45 @@ app.get(`/version`, (req, res) => {
});
});

// Explicit robots.txt endpoint with proper security headers
app.get('/robots.txt', (req, res) => {
res.setHeader('Content-Type', 'text/plain');
res.setHeader('Cache-Control', 'public, max-age=86400');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.send('User-agent: *\nDisallow: /');
});

// Explicit sitemap.xml endpoint with proper security headers
app.get('/sitemap.xml', (req, res) => {
res.setHeader('Content-Type', 'application/xml');
res.setHeader('Cache-Control', 'public, max-age=86400');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.send('<?xml version="1.0" encoding="UTF-8"?>\n<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">\n</urlset>');
});

// Handle trailing slash redirects for robots.txt and sitemap.xml
app.get('/robots.txt/', (req, res) => {
res.redirect(301, '/robots.txt');
});

app.get('/sitemap.xml/', (req, res) => {
res.redirect(301, '/sitemap.xml');
});

app.use((req, res, next) => {
if (PERMISSIONS_POLICY) {
res.setHeader("Permissions-Policy", PERMISSIONS_POLICY);
}

// Additional security headers to address ZAP scan issues
res.setHeader('Cross-Origin-Embedder-Policy', 'require-corp');
res.setHeader('Cross-Origin-Opener-Policy', 'same-origin');
res.setHeader('Cross-Origin-Resource-Policy', 'same-origin');
res.setHeader('X-Content-Type-Options', 'nosniff');
res.setHeader('Referrer-Policy', 'strict-origin-when-cross-origin');

next();
});

Expand Down