Skip to content

Importer variable nomenclature is not compatible with fava #195

@mlell

Description

@mlell

fava v1.30.7 expects the importer configuration to be a Python module with the variables CONFIG and HOOKS:

https://github.com/beancount/fava/blob/d6968fa0c3a48d42365532167faa23a4550a04f4/src/fava/core/ingest.py#L334-L336

However, the example calls them importers and hooks.

importers = [
utrade.Importer(
"USD",
"Assets:US:UTrade",
"Assets:US:UTrade:Cash",
"Income:US:UTrade:{}:Dividend",
"Income:US:UTrade:{}:Gains",
"Expenses:Financial:Fees",
"Assets:US:BofA:Checking",
),
ofx.Importer("379700001111222", "Liabilities:US:CreditCard", "bofa"),
acme.Importer("Assets:US:ACMEBank"),
csvbank.Importer("Assets:US:CSVBank", "USD"),
]

This is confusing and not documented anywhere. How about renaming the variables in the example? This would make things easier for new users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions