Should up-to-date indicators ignore pending transactions?

[intrigeri]

Hi! First of all, thank you so much for Fava :)

On 1 of my accounts, I have a bunch of transactions with a date in the future to encode planned expenses that I have committed to make. I have enabled the up-to-date indicator for all accounts I have at that bank. As a result, for this account I see "The last entry is not a balance check".

Would it make sense, for the purpose of determining up-to-date'ness, to ignore pending transactions after the last balance check?

[yagebu]

What would mark a "pending" transaction for you? A specific flag?

[intrigeri]

What would mark a "pending" transaction for you? A specific flag?

Yes, the `!` flag, which https://beancount.github.io/docs/beancount_language_syntax.html#transactions recommends using for "Incomplete transaction, needs confirmation or revision". On Fava's Journal page, the hover tooltip for the `!` button is "Pending transactions".

[yagebu]

I don't have a strong opinion on this one, so sure, why not. Do you want to create a PR for this?

[intrigeri]

I don't plan to (mostly because I would need to learn my way around the code base and dev process), but who knows what might happen on a rainy Sunday :)