Skip to content

fix: Add .js extension to dynamic imports in ES modules #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afterthought wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add .js extension to dynamic imports in ES modules #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/fix-imports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ files.forEach((file) => {
'from "$1.js"'
);

// Add .js to dynamic imports without extensions
content = content.replace(
/import\(['"](\.\.[\/\\][^'"]+?)(?<!\.js)['"]\)/g,
'import("$1.js")'
);
content = content.replace(
/import\(['"](\.[\/\\][^'"]+?)(?<!\.js)['"]\)/g,
'import("$1.js")'
);

writeFileSync(file, content);
});

Expand Down
2 changes: 1 addition & 1 deletion src/tools/worktree-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const worktreeChanges = {
);
if (worktreesWithoutMetadata.length > 0) {
const { ensureWorktreeHasMetadata } = await import(
"./worktree-lifecycle"
"./worktree-lifecycle.js"
);
await WorktreeMetadataManager.ensureMetadataForWorktrees(
worktreesWithoutMetadata.map((wt) => wt.worktreePath),
Expand Down
4 changes: 2 additions & 2 deletions src/tools/worktree-lifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,15 +599,15 @@ export const cleanWorktrees = {

try {
// Try to get diff stats from base branch
const { gitDiffStats } = await import("@/src/utils/git");
const { gitDiffStats } = await import("@/src/utils/git.js");
const diffStats = await gitDiffStats(baseBranch, "HEAD", {
cwd: worktree.worktreePath,
});
hasCommittedChanges = diffStats.files > 0;
} catch (error) {
// If diff fails, try origin/baseBranch
try {
const { gitDiffStats } = await import("@/src/utils/git");
const { gitDiffStats } = await import("@/src/utils/git.js");
const diffStats = await gitDiffStats(
`origin/${baseBranch}`,
"HEAD",
Expand Down