App startup script to enable more flexible deployments based on environment variables #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following best practies and in tandem with other PRs that remove the complexity of hardcoding different scenarios of deployment and configuration via different files or environment vatiableds. This PR introduces a start.sh file which will serve as the entrypoint to the application and it will use the different environment variables to tailor the deployment or configuration that the user desires based on environment variables.
This script should not make decision for the user based on something like ENVIRONMENT env variable where the user ays if it is local or productions or etc. instead the user needs to be epxlicit on which functionality or configuration it wants.