From 8a1fd228be26796ffa65b074e3da2d3f948cdc80 Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:43:11 +0100 Subject: [PATCH 1/6] Update ReentrantERC20.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- test/mock/token/ReentrantERC20.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/mock/token/ReentrantERC20.sol b/test/mock/token/ReentrantERC20.sol index 2e2a925..5a29bac 100644 --- a/test/mock/token/ReentrantERC20.sol +++ b/test/mock/token/ReentrantERC20.sol @@ -4,7 +4,7 @@ pragma solidity 0.8.26; import "./MockERC20.sol"; import { IDistributor } from "src/pol/interfaces/IDistributor.sol"; -/// @dev For test purposes this contract simulate a malicius ERC20 +/// @dev For test purposes this contract simulate a malicious ERC20 /// that try to reentrancy attack the distributor contract contract ReentrantERC20 is MockERC20 { address internal distributor; From 08dce9158c2ce91359814a49230d18b899ebf71f Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:43:45 +0100 Subject: [PATCH 2/6] Update RewardVault.t.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- test/pol/RewardVault.t.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pol/RewardVault.t.sol b/test/pol/RewardVault.t.sol index 4104a96..5dd42a2 100644 --- a/test/pol/RewardVault.t.sol +++ b/test/pol/RewardVault.t.sol @@ -804,7 +804,7 @@ contract RewardVaultTest is DistributorTest, StakingTest { assertEq(updatedAmountRemaining, amountToAdd1 + insufficientAmountToAdd); } - // test the increase in incentive rate when amoutRemaining is not required to be 0. + // test the increase in incentive rate when amountRemaining is not required to be 0. function testFuzz_AddIncentive_IncreaseIncentiveRate(uint256 newIncentiveRate) public { newIncentiveRate = bound(newIncentiveRate, 200 * 1e18 + 1, 1e36); // updates the incentive rate to 200 * 1e18 while minRate is 100 * 1e18. From 8a842b7c9482dedab7bc56b7fd93658ad6a40191 Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:44:30 +0100 Subject: [PATCH 3/6] Update BeraChef.t.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- test/pol/BeraChef.t.sol | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/pol/BeraChef.t.sol b/test/pol/BeraChef.t.sol index 6b5ebbb..3dc2a04 100644 --- a/test/pol/BeraChef.t.sol +++ b/test/pol/BeraChef.t.sol @@ -226,8 +226,8 @@ contract BeraChefTest is POLTest { /// @dev Should fail if default reward allocation contains a weight percentage equal to 0 function testFail_SetDefaultRewardAllocationWithZeroPercentageWeight() public { - address receiverOne = makeAddr("recevierOne"); - address receiverTwo = makeAddr("recevierTwo"); + address receiverOne = makeAddr("receiverOne"); + address receiverTwo = makeAddr("receiverTwo"); IBeraChef.Weight[] memory weights = new IBeraChef.Weight[](3); weights[0] = IBeraChef.Weight(receiver, 5000); weights[1] = IBeraChef.Weight(receiverOne, 0); @@ -305,8 +305,8 @@ contract BeraChefTest is POLTest { /// @dev Should fail if reward allocation contains a weight percentage equal to 0 function test_FailIfZeroRewardAllocationWeight() public { - address receiverOne = makeAddr("recevierOne"); - address receiverTwo = makeAddr("recevierTwo"); + address receiverOne = makeAddr("receiverOne"); + address receiverTwo = makeAddr("receiverTwo"); IBeraChef.Weight[] memory weights = new IBeraChef.Weight[](3); weights[0] = IBeraChef.Weight(receiver, 5000); weights[1] = IBeraChef.Weight(receiverOne, 0); From 8b93ebfb299a366f7ccf78125a81d1a386929936 Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:45:04 +0100 Subject: [PATCH 4/6] Update Honey.t.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- test/honey/Honey.t.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/honey/Honey.t.sol b/test/honey/Honey.t.sol index 4276c06..e75395e 100644 --- a/test/honey/Honey.t.sol +++ b/test/honey/Honey.t.sol @@ -335,7 +335,7 @@ contract HoneyTest is StdCheats, SoladyTest { // Initialize the faultyHoney through the proxy FaultyMockHoney(address(honey)).initialize(faultyHoneyOwner); - // Factory slot has not initializated on the Proxy storage + // Factory slot has not initialized on the Proxy storage // So factory is equal to address(0) // "collidedFactoryValue" variable instead, has taken the value of the factory address // since it's pointing to the "original" factory slot of the storage From 1f10282231de19725147000796e6147aaeba7d8b Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:45:50 +0100 Subject: [PATCH 5/6] Update BlockRewardController.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- src/pol/rewards/BlockRewardController.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pol/rewards/BlockRewardController.sol b/src/pol/rewards/BlockRewardController.sol index 3d9a161..51c7187 100644 --- a/src/pol/rewards/BlockRewardController.sol +++ b/src/pol/rewards/BlockRewardController.sol @@ -232,7 +232,7 @@ contract BlockRewardController is IBlockRewardController, OwnableUpgradeable, UU emit BlockRewardProcessed(pubkey, nextTimestamp, base, reward); - // Use the beaconDepositContract to fetch the operator, Its gauranteed to return a valid address. + // Use the beaconDepositContract to fetch the operator, Its guaranteed to return a valid address. // Beacon Deposit contract will enforce validators to set an operator. address operator = beaconDepositContract.getOperator(pubkey); if (base > 0) bgt.mint(operator, base); From ad75ab4177642571267d6a6620581f0c11bfafc2 Mon Sep 17 00:00:00 2001 From: kilavvy <140459108+kilavvy@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:46:27 +0100 Subject: [PATCH 6/6] Update BlockRewardController.sol Signed-off-by: kilavvy <140459108+kilavvy@users.noreply.github.com> --- src/pol/rewards/BlockRewardController.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pol/rewards/BlockRewardController.sol b/src/pol/rewards/BlockRewardController.sol index 51c7187..f52ab23 100644 --- a/src/pol/rewards/BlockRewardController.sol +++ b/src/pol/rewards/BlockRewardController.sol @@ -57,7 +57,7 @@ contract BlockRewardController is IBlockRewardController, OwnableUpgradeable, UU /// @notice The minimum reward rate for BGT after accounting for validator boosts. uint256 public minBoostedRewardRate; - /// @notice The boost mutliplier param in the function, determines the inflation cap, 18 dec. + /// @notice The boost multiplier param in the function, determines the inflation cap, 18 dec. uint256 public boostMultiplier; /// @notice The reward convexity param in the function, determines how fast it converges to its max, 18 dec.