Are error code like BE_IO_ERROR actually used?

[Conaclos]

Hi!

Using Berry FFI, I noticed that only BE_OK, BE_EXIT and BE_EXCEPTION were returned by function returning a status code.
It seems that syntax error, io errors, and exec errors always produces an exception and thus always returns a BE_EXCEPTION.
BE_SYNTAX_ERROR, BE_IO_ERROR, and BE_EXEC_ERROR seems to be unused.
I am not sure about BE_MALLOC_ERROR because I was not able to produce a malloc error yet.

Investigating a bit in berry internals, I found be_getexcept that returns BE_SYNTAX_ERROR, BE_IO_ERROR, and BE_EXEC_ERROR by looking at an exception. The function seems not to be called in the code base.

Are BE_MALLOC_ERROR, BE_SYNTAX_ERROR, BE_IO_ERROR, and BE_EXEC_ERROR actually used?

[Conaclos]

Also, bntvfunc must return a int. I first thought it was a status code, however it seems to be completely ignored. What is its purpose?

[s-hadinger]

I need to check deeper in the source, but indeed it looks like the int return value is always 0 and ignored in CALL opcode. This may be an interesting optimization to change all functions from int to void and may reduce code size. Errors are supposed to use exception which bypasses the return code.

[s-hadinger]

I checked quickly, this would save 2KB of flash for Tasmota, so not bad at all.

[Conaclos]

@s-hadinger Have you some clues about the main question?

[s-hadinger]

The values BE_OK, BE_EXIT and BE_EXCEPTION are still used in some portion of the code, but indeed there are situations when they are hidden within exception.