Improve debug logging (#4354)

* Improve debug logging

* Remove condition

* Update logHead

Author: haslinghuis

src/js/port_handler.js

@@ -9,6 +9,8 @@ const DEFAULT_PORT = "noselection";
 const DEFAULT_BAUDS = 115200;
 
 const PortHandler = new (function () {
+    this.logHead = "[PORTHANDLER]";
+
     this.currentSerialPorts = [];
     this.currentUsbPorts = [];
     this.currentBluetoothPorts = [];
@@ -118,15 +120,15 @@ PortHandler.updateCurrentSerialPortsList = async function () {
     const ports = await serial.getDevices();
     const orderedPorts = this.sortPorts(ports);
     this.portAvailable = orderedPorts.length > 0;
-
+    console.log(`${this.logHead} Found serial port`, orderedPorts);
     this.currentSerialPorts = [...orderedPorts];
 };
 
 PortHandler.updateCurrentUsbPortsList = async function () {
     const ports = await usb.getDevices();
     const orderedPorts = this.sortPorts(ports);
     this.dfuAvailable = orderedPorts.length > 0;
-
+    console.log(`${this.logHead} Found DFU port`, orderedPorts);
     this.currentUsbPorts = [...orderedPorts];
 };
 
@@ -135,7 +137,7 @@ PortHandler.updateCurrentBluetoothPortsList = async function () {
         const ports = await BT.getDevices();
         const orderedPorts = this.sortPorts(ports);
         this.bluetoothAvailable = orderedPorts.length > 0;
-
+        console.log(`${this.logHead} Found bluetooth port`, orderedPorts);
         this.currentBluetoothPorts = [...orderedPorts];
     }
 };
@@ -236,11 +238,10 @@ PortHandler.selectActivePort = function (suggestedDevice) {
     // Return the default port if no other port was selected
     this.portPicker.selectedPort = selectedPort || DEFAULT_PORT;
 
-    console.log(`[PORTHANDLER] automatically selected device is '${this.portPicker.selectedPort}'`);
-
-    // hack to update Vue component
-    const p = document.getElementById("port");
-    p.value = this.portPicker.selectedPort;
+    console.log(
+        `${this.logHead} Automatically selected device is '${this.portPicker.selectedPort}' - suggested:`,
+        suggestedDevice,
+    );
 
     return selectedPort;
 };

src/js/protocols/bluetooth.js

@@ -58,6 +58,8 @@ class BT extends EventTarget {
     constructor() {
         super();
 
+        this.logHead = "[BLUETOOTH]";
+
         if (!this.bluetooth && window && window.navigator && window.navigator.bluetooth) {
             this.bluetooth = navigator.bluetooth;
         } else {
@@ -77,8 +79,6 @@ class BT extends EventTarget {
         this.bytesReceived = 0;
         this.failed = 0;
 
-        this.logHead = "[BLUETOOTH]";
-
         this.portCounter = 0;
         this.devices = [];
         this.device = null;

src/js/protocols/websocket.js

@@ -2,6 +2,8 @@ class WebsocketSerial extends EventTarget {
     constructor() {
         super();
 
+        this.logHead = "[WEBSOCKET]";
+
         this.connected = false;
         this.connectionInfo = null;
 
@@ -10,8 +12,6 @@ class WebsocketSerial extends EventTarget {
         this.bytesReceived = 0;
         this.failed = 0;
 
-        this.logHead = "[WEBSOCKET] ";
-
         this.address = "ws://localhost:5761";
 
         this.ws = null;