Skip to content

Change the Mali GPUs denylist of GPU preprocessing to Culling level #21955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

Change the Mali GPUs denylist of GPU preprocessing to Culling level #21955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions crates/bevy_render/src/batching/gpu_preprocessing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,10 +1103,14 @@ impl FromWorld for GpuPreprocessingSupport {
// Filter Android drivers that are incompatible with GPU preprocessing:
// - We filter out Adreno 730 and earlier GPUs (except 720, as it's newer
// than 730).
// - We filter out Mali GPUs with driver versions lower than 48.
fn is_non_supported_android_device(adapter_info: &RenderAdapterInfo) -> bool {
fn is_preprocessing_unsupported_android_device(adapter_info: &RenderAdapterInfo) -> bool {
crate::get_adreno_model(adapter_info).is_some_and(|model| model != 720 && model <= 730)
|| crate::get_mali_driver_version(adapter_info).is_some_and(|version| version < 48)
}

// Filter Android drivers that are incompatible with GPU culling:
// - We filter out Mali GPUs with driver versions lower than 48.
fn is_culling_unsupported_android_device(adapter_info: &RenderAdapterInfo) -> bool {
crate::get_mali_driver_version(adapter_info).is_some_and(|version| version < 48)
}

let culling_feature_support = device.features().contains(
Expand All @@ -1130,15 +1134,17 @@ impl FromWorld for GpuPreprocessingSupport {
let adapter_info = RenderAdapterInfo(WgpuWrapper::new(adapter.get_info()));

let max_supported_mode = if device.limits().max_compute_workgroup_size_x == 0
|| is_non_supported_android_device(&adapter_info)
|| adapter_info.backend == wgpu::Backend::Gl
|| is_preprocessing_unsupported_android_device(&adapter_info)
{
info!(
"GPU preprocessing is not supported on this device. \
Falling back to CPU preprocessing.",
);
GpuPreprocessingMode::None
} else if !(culling_feature_support && limit_support && downlevel_support) {
} else if !(culling_feature_support && limit_support && downlevel_support)
|| is_culling_unsupported_android_device(&adapter_info)
{
info!("Some GPU preprocessing are limited on this device.");
GpuPreprocessingMode::PreprocessingOnly
} else {
Expand Down