-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Don't update the text buffer in text_system
#21966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ickshonpe
wants to merge
13
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:separate-text-info-info-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Don't update the text buffer in text_system
#21966
ickshonpe
wants to merge
13
commits into
bevyengine:main
from
ickshonpe:separate-text-info-info-updates
+230
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onpe/bevy into buffer-dimensions-refactor
* Added `render_text` method to `TextPipeline` that only updates the `TextLayoutInfo` with updating the text's `CosmicBuffer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Text
Rendering and layout for characters
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Performance
A change motivated by improving speed, memory usage or compile times
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Text is shaped in
measure_text_system. When the schedule reachestext_systemthere's no need to reupdate the cosmic-text buffer a second time.text_systemshould only be updating any staleTextLayoutInfocomponents.Solution
update_text_layout_infotoTextPipeline. This method updates the givenTextLayoutInfowithout performing any shaping.update_text_layout_infoinstead ofqueue_textfromtext_system.TextFont, instead of the fullTextUiReader.There are some more changes that seem desirable, the glyph info updates should probably be done in
measure_systemfor instance, but I'll leave those for followup PRs.Testing
yellow = this PR, red = main