From 67aa2ae2d096a219f4ab56c77688016a75d85da4 Mon Sep 17 00:00:00 2001 From: = <=> Date: Thu, 29 Aug 2024 13:18:05 +0300 Subject: [PATCH] chore: rename withFilterMap to skipOnCondition --- ...perator.spec.ts => skip-on-condition.operator.spec.ts} | 8 ++++---- ...lter-map.operator.ts => skip-on-condition.operator.ts} | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) rename packages/rxjs/src/operators/{with-filter-map.operator.spec.ts => skip-on-condition.operator.spec.ts} (80%) rename packages/rxjs/src/operators/{with-filter-map.operator.ts => skip-on-condition.operator.ts} (96%) diff --git a/packages/rxjs/src/operators/with-filter-map.operator.spec.ts b/packages/rxjs/src/operators/skip-on-condition.operator.spec.ts similarity index 80% rename from packages/rxjs/src/operators/with-filter-map.operator.spec.ts rename to packages/rxjs/src/operators/skip-on-condition.operator.spec.ts index e1267da..03c366b 100644 --- a/packages/rxjs/src/operators/with-filter-map.operator.spec.ts +++ b/packages/rxjs/src/operators/skip-on-condition.operator.spec.ts @@ -1,8 +1,8 @@ import { Observable, of } from 'rxjs'; import { toArray } from 'rxjs/operators'; -import { withFilterMap } from './with-filter-map.operator'; +import { skipOnCondition } from './skip-on-condition.operator'; -describe('with-filter-map.operator.ts', () => { +describe('skip-on-condition.operator.ts', () => { it('should filter values correctly when predicate returns true', (done: jest.DoneCallback) => { const source$: Observable = of('a', 'b', 'c'); const other$: Observable = of(true); @@ -11,7 +11,7 @@ describe('with-filter-map.operator.ts', () => { source$ .pipe( - withFilterMap(other$, (value: boolean) => value), + skipOnCondition(other$, (value: boolean) => value), toArray() ) .subscribe({ @@ -28,7 +28,7 @@ describe('with-filter-map.operator.ts', () => { source$ .pipe( - withFilterMap(other$, (value: boolean) => value), + skipOnCondition(other$, (value: boolean) => value), toArray() ) .subscribe({ diff --git a/packages/rxjs/src/operators/with-filter-map.operator.ts b/packages/rxjs/src/operators/skip-on-condition.operator.ts similarity index 96% rename from packages/rxjs/src/operators/with-filter-map.operator.ts rename to packages/rxjs/src/operators/skip-on-condition.operator.ts index ebba2c0..eb4737d 100644 --- a/packages/rxjs/src/operators/with-filter-map.operator.ts +++ b/packages/rxjs/src/operators/skip-on-condition.operator.ts @@ -13,7 +13,7 @@ import { filter, map, withLatestFrom } from 'rxjs/operators'; * The source value is emitted only if the predicate returns true. * @returns An operator function that returns an observable emitting the source values that pass the predicate check. */ -export function withFilterMap( +export function skipOnCondition( other$: Observable, predicate: (otherValue: O) => boolean ): OperatorFunction {