Don't use ?array type hint in ext attributes

shochdoerfer · shochdoerfer · commit 1c3cf10576c8 · 2022-09-25T20:04:14.000+02:00
diff --git a/src/bitExpert/PHPStan/Magento/Autoload/ExtensionAutoloader.php b/src/bitExpert/PHPStan/Magento/Autoload/ExtensionAutoloader.php
@@ -93,7 +93,7 @@ public function getFileContents(string $className): string
             // converted to just an array
             $paramType = $type;
             if (strpos($type, '[]') !== false) {
-                $paramType = '?array';
+                $paramType = null;
             }
 
             $generator->addMethodFromGenerator(
diff --git a/src/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloader.php b/src/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloader.php
@@ -109,7 +109,7 @@ public function getFileContents(string $interfaceName): string
             // converted to just an array
             $paramType = $type;
             if (strpos($type, '[]') !== false) {
-                $paramType = '?array';
+                $paramType = null;
             }
 
             $generator->addMethodFromGenerator(

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public function getFileContents(string $className): string`
`93`	`93`	`// converted to just an array`
`94`	`94`	`$paramType = $type;`
`95`	`95`	`if (strpos($type, '[]') !== false) {`
`96`		`- $paramType = '?array';`
	`96`	`+ $paramType = null;`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`$generator->addMethodFromGenerator(`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function getFileContents(string $interfaceName): string`
`109`	`109`	`// converted to just an array`
`110`	`110`	`$paramType = $type;`
`111`	`111`	`if (strpos($type, '[]') !== false) {`
`112`		`- $paramType = '?array';`
	`112`	`+ $paramType = null;`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`$generator->addMethodFromGenerator(`