Merge pull request #274 from shochdoerfer/fix/ext_attr_array

Don't use ?array type hint in ext attributes

Author: shochdoerfer

src/bitExpert/PHPStan/Magento/Autoload/ExtensionAutoloader.php

@@ -89,13 +89,6 @@ public function getFileContents(string $className): string
              * @see \Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator::_getClassMethods
              */
 
-            // treat array types properly in the generated code. Similar to Magento core MyInterface[] type gets
-            // converted to just an array
-            $paramType = $type;
-            if (strpos($type, '[]') !== false) {
-                $paramType = '?array';
-            }
-
             $generator->addMethodFromGenerator(
                 MethodGenerator::fromArray([
                     'name' => 'get' . ucfirst($propertyName),
@@ -109,7 +102,7 @@ public function getFileContents(string $className): string
             $generator->addMethodFromGenerator(
                 MethodGenerator::fromArray([
                     'name' => 'set' . ucfirst($propertyName),
-                    'parameters' => [new ParameterGenerator($propertyName, $paramType)],
+                    'parameters' => [$propertyName],
                     'docblock' => DocBlockGenerator::fromArray([
                         'tags' => [
                             new ParamTag($propertyName, [$type]),

src/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloader.php

@@ -105,13 +105,6 @@ public function getFileContents(string $interfaceName): string
              * @see \Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator::_getClassMethods
              */
 
-            // treat array types properly in the generated code. Similar to Magento core MyInterface[] type gets
-            // converted to just an array
-            $paramType = $type;
-            if (strpos($type, '[]') !== false) {
-                $paramType = '?array';
-            }
-
             $generator->addMethodFromGenerator(
                 MethodGenerator::fromArray([
                     'name' => 'get' . ucfirst($propertyName),
@@ -125,7 +118,7 @@ public function getFileContents(string $interfaceName): string
             $generator->addMethodFromGenerator(
                 MethodGenerator::fromArray([
                     'name' => 'set' . ucfirst($propertyName),
-                    'parameters' => [new ParameterGenerator($propertyName, $paramType)],
+                    'parameters' => [$propertyName],
                     'docblock' => DocBlockGenerator::fromArray([
                         'tags' => [
                             new ParamTag($propertyName, [$type]),