Merge pull request #283 from hostep/fixes-issue-282

Adds PHP 8.2 / Magento 2.4.6 support

Author: shochdoerfer

composer.json

@@ -22,7 +22,7 @@
   "require": {
     "php": "^7.2.0 || ^8.1.0",
     "ext-dom": "*",
-    "laminas/laminas-code": "~3.3.0 || ~3.4.1 || ~3.5.1 || ~4.5.0 || ~4.5.2",
+    "laminas/laminas-code": "~3.3.0 || ~3.4.1 || ~3.5.1 || ^4.5",
     "phpstan/phpstan": "~1.9.2",
     "symfony/finder": "^3.0 || ^4.0 || ^5.0 || ^6.0"
   },

src/bitExpert/PHPStan/Magento/Autoload/DataProvider/ExtensionAttributeDataProvider.php

@@ -50,7 +50,7 @@ public function getAttributesForInterface(string $sourceInterface): array
         foreach ($this->getExtensionAttributesXmlDocs() as $doc) {
             $xpath = new DOMXPath($doc);
             $attrs = $xpath->query(
-                "//extension_attributes[@for=\"${sourceInterface}\"]/attribute",
+                sprintf('//extension_attributes[@for="%s"]/attribute', $sourceInterface),
                 $doc->documentElement
             );
 

src/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloader.php

@@ -90,7 +90,9 @@ public function getFileContents(string $interfaceName): string
 
         // Magento only creates extension attribute interfaces for existing interfaces; retain that logic
         if (!$this->classLoaderProvider->exists($sourceInterface)) {
-            throw new \InvalidArgumentException("${sourceInterface} does not exist and has no extension interface");
+            throw new \InvalidArgumentException(
+                sprintf('%s does not exist and has no extension interface', $sourceInterface)
+            );
         }
 
         $generator = new InterfaceGenerator();

tests/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloaderUnitTest.php

@@ -96,6 +96,7 @@ public function autoloaderUsesCachedFileWhenFound(): void
     public function autoloadDoesNotGenerateInterfaceWhenNoAttributesExist(): void
     {
         $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('NonExistentInterface does not exist and has no extension interface');
 
         $interfaceName = 'NonExistentExtensionInterface';