boxing the heavyweight ExtractTxError

Author: ulrichard

.github/workflows/cont_integration.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.81.0 # current
+          - 1.89.0 # current
           - 1.63.0 # MSRV
     steps:
       - name: checkout
@@ -48,7 +48,7 @@ jobs:
           cargo update -p base64ct --precise "1.6.0"
           cargo update -p minreq --precise "2.13.2"
           cargo update -p bdk_electrum --precise 0.20.1
-          cargo update -p rustls:0.23.26 --precise 0.23.12
+          cargo update -p rustls:0.23.28 --precise 0.23.12
       - name: Build
         run: cargo build
       - name: Clippy

Dockerfile

@@ -1,4 +1,4 @@
-FROM rust:1.81-bookworm
+FROM rust:1.87-bookworm
 ARG http_proxy
 ENV http_proxy=$http_proxy
 ENV https_proxy=$http_proxy
@@ -35,7 +35,4 @@ WORKDIR /home/satoshi
 
 RUN rustup component add clippy-preview \
  && rustup component add rustfmt
-RUN rustup target add wasm32-unknown-unknown
-RUN rustup target add wasm32-wasi
-RUN rustup target add wasm32-unknown-emscripten
 

Dockerfile_63

@@ -34,6 +34,4 @@ WORKDIR /home/satoshi
 
 RUN rustup component add clippy-preview \
  && rustup component add rustfmt
-RUN rustup target add wasm32-unknown-unknown
-RUN rustup target add wasm32-wasi
 

Makefile

@@ -26,7 +26,7 @@ test_63: builder_63
 	$(DOCKER_RUN) ${TAG_63} cargo update -p base64ct --precise "1.6.0" || true
 	$(DOCKER_RUN) ${TAG_63} cargo update -p minreq --precise "2.13.2" || true
 	$(DOCKER_RUN) ${TAG_63} cargo update -p bdk_electrum --precise 0.20.1 || true
-	$(DOCKER_RUN) ${TAG_63} cargo update -p rustls:0.23.26 --precise 0.23.12 || true
+	$(DOCKER_RUN) ${TAG_63} cargo update -p rustls:0.23.28 --precise 0.23.12 || true
 	$(DOCKER_RUN) ${TAG_63} cargo test
 
 run: builder

README.md

@@ -65,7 +65,7 @@ cargo update -p once_cell --precise "1.20.3"
 cargo update -p base64ct --precise "1.6.0"
 cargo update -p minreq --precise "2.13.2"
 cargo update -p bdk_electrum --precise 0.20.1
-cargo update -p rustls:0.23.26 --precise 0.23.12
+cargo update -p rustls:0.23.28 --precise 0.23.12
 ```
 
 ## Contribution

src/reserves.rs

@@ -86,7 +86,7 @@ pub enum ProofError {
     /// Failed to create a transaction
     TxError(CreateTxError),
     /// Failed to extract TX from a PSBT
-    TxExtraction(ExtractTxError),
+    TxExtraction(Box<ExtractTxError>),
     /// Failed to construct a Wallet
     Wallet(bdk_wallet::descriptor::error::Error),
     /// Failed to sign a transaction
@@ -107,7 +107,7 @@ impl From<CreateTxError> for ProofError {
 
 impl From<ExtractTxError> for ProofError {
     fn from(error: ExtractTxError) -> Self {
-        ProofError::TxExtraction(error)
+        ProofError::TxExtraction(Box::new(error))
     }
 }