Let proposal_update_operation fail if it approves a proposal but the proposal fails to execute

[mastercyb]

I suppose that proper behavior is not to confirm approval in this case

[abitmore]

UI issue? Report to https://github.com/bitshares/bitshares-ui/issues?

[mastercyb]

Is not UI issue. My point is that the blockchain should not accept such approval throwing error

[abitmore]

It's a feature.

When updating a proposal (add or remove approvals) without a review period(e.g. committee proposals which will only execute on expiration), if the authority threshold is met after the update, the proposal will be tried to execute immediately. If the execution failed, for example due to insufficient fee, the proposal will be left there waiting for future update, or expiration. It will be tried to execute again after another update if still has enough approvals. It will be tried again on expiration. Related code is here

So in your case, you can transfer enough fund to the account then try to approve the proposal again.

Actually, what we need is a method to notify related parties when a proposal is failed to execute.

[abitmore]

@21xhipster IMHO your suggestion makes sense as well. However, changing of behavior requires a hard fork. Hope others join the discussion.

[pmconrad]

IMO the behaviour of the blockchain is OK, because it doesn't break anything. A complete fix in the suggested form is close to impossible, because the problem situation can be created in many different ways.

[abitmore]

About implementation, for example we can re-throw the fc::exception when the proposal is failed to execute, rather than catching it and do nothing.

[xiangxn]

Is there a good way to log errors and return them to the UI? All I can think of is adding fields to proposals.

[abitmore]

Note:

• need to update proposal tests added in Fix #584 authorize transactions with non-immediate owner authorities #1259 after implemented this feature.