Skip to content

Commit b796954

Browse files
committed
clarify guidance; update ADR 0003
1 parent c7ac12a commit b796954

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

docs/architecture/adr/0003-observable-data-services.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,14 @@ Chosen option: **Observable data services**, because
3333
- The work towards a reactive data model will allow us to adopt patterns like NGRX in the future
3434
should it be needed.
3535

36+
:::info Updated Guidance
37+
38+
This ADR remains valid for business logic services, but
39+
[ADR 0029](/architecture/adr/0029-angular-signals) introduces Angular Signals as the preferred
40+
approach over RxJS for view layer code (components, directives, pipes, and UI-coupled services).
41+
42+
:::
43+
3644
### Example
3745

3846
#### Organizations

docs/architecture/adr/0029-angular-signals.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ linting:
3232
- `@Output()``output()`
3333
- `@ViewChild`/`@ContentChild``viewChild()`/`contentChild()`
3434

35-
Services tightly coupled to Angular should use signals. Services with business logic should prefer
36-
RxJS for portability. Use `toSignal()` and `toObservable()` to bridge between RxJS and signals when
37-
necessary.
35+
Services tightly coupled to Angular should use signals. Services with non-presentational business
36+
logic should prefer RxJS for portability. Use `toSignal()` and `toObservable()` to bridge between
37+
RxJS and signals when necessary.
3838

3939
## Implementation Plan
4040

@@ -46,6 +46,10 @@ automatic code migrations for signal
4646
Much of `libs/components` was updated using these migrators:
4747
https://github.com/bitwarden/clients/pull/15340
4848

49+
See the
50+
[Angular Modernization Guide](https://contributing.bitwarden.com/contributing/code-style/web/angular-migration-guide/#signals)
51+
for more information.
52+
4953
## Consequences
5054

5155
**Positive:**

0 commit comments

Comments
 (0)