Commit 1cc3a8d
authored
Pm 28544 fix publish rust crates (#601)
## 🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28544
## 📔 Objective
This PR updates the cargo publishing workflow to use explicit package
inclusion instead of exclusion-based logic. The workflow now explicitly
lists the 14 crates from sdk-internal that sdk-sm depends on, preventing
accidental publication of unintended crates. This script was pointed at
`sdk-sm/Cargo.lock` to get the list of crates:
``` bash
grep -B 2 'source = "git+https://github.com/bitwarden/sdk-internal.git' Cargo.lock | \
grep '^name = ' | \
cut -d'"' -f2 | \
sort
```
This PR also fixes an invalid license file reference in
=bitwarden-commercial-vault/Cargo.toml= - changed from the non-existent
`LICENSE_BITWARDEN.txt` to the correct `LICENSE_SDK.txt`.
These changes have been bundled together because they are both small,
and both support publishing the sdk crates for sm.
## 🚨 Breaking Changes
<!-- Does this PR introduce any breaking changes? If so, please describe
the impact and migration path for clients.
If you're unsure, the automated TypeScript compatibility check will run
when you open/update this PR and provide feedback.
For breaking changes:
1. Describe what changed in the client interface
2. Explain why the change was necessary
3. Provide migration steps for client developers
4. Link to any paired client PRs if needed
Otherwise, you can remove this section. -->
## ⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
team
## 🦮 Reviewer guidelines
<!-- Suggested interactions but feel free to use (or not) as you desire!
-->
- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or 1 parent a8a19d3 commit 1cc3a8d
File tree
2 files changed
+20
-2
lines changed- .github/workflows
- bitwarden_license/bitwarden-commercial-vault
2 files changed
+20
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
125 | 143 | | |
126 | 144 | | |
127 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments