Support `paths` Github Filter pattern

[zomars]

Does the paths options accept a negated wildcard path or is it necessary to add a paths-ignore option? Thank you BTW this is very useful 🙏🏽

[zomars]

Sorry to bother, but does this follow the Github Filter pattern ?

I'm finding some inconsistencies between a regular check path and this action path.

For example I have type check like this:

name: Check types
on:
  pull_request_target:
    branches:
      - main
    paths:
      - '**.tsx?'
jobs:
  check-types:
    steps:
      - run: yarn type-check

and this on my conditional check:

name: "Meta Workflow: Require Conditional Status Checks"

on:
  pull_request:
    branches:
      - main

jobs:
  required-checks:
    strategy:
      matrix:
        node: ["16.x"]
        os: [ubuntu-latest]
    runs-on: ${{ matrix.os }}
    timeout-minutes: 15
    steps:
      - name: Ensure All Conditional Checks Have Passed
        uses: blend/require-conditional-status-checks@2022.02.04
        with:
          interval: 20s
          checks-yaml: |
            - job: check-types
              paths:
                - '**.tsx?'

This runs Check types when I modify a .ts or .tsx file but on the required-checks job, check-types doesn't appear as a required check.

Am I missing something? Thanks again for your attention 🙏🏽

EDIT:

Maybe I'm just tired but I'm testing with a simple PR that modifies a json and ts file:

And according to my config it should run check-types

But actually is running ALL but check-types. Am I making sense?

[zomars]

Made a small repro BTW

[zomars]

@dhermes sorry for tagging you but I feel like I'm so close to pinpointing the issue. I'm no golang expert tho.

Netiher extension wildcard (**.ts ) nor negated paths (!apps/** ) works right now. I would need to strictly use opt-in directory wildcards (packages/**).

Can you point me to the could I would need to update to add support for this? I can try coming up with a PR myself. 🙏🏽

[zomars]

This condition:

require-conditional-status-checks/pkg/gitignore/gitignore.go

Lines 40 to 42 in f71534c

	if strings.HasPrefix(pattern, "!") {
	return !GitignoreMatch(filename, pattern[1:])
	}

And this one I think are conflicting:

require-conditional-status-checks/pkg/gitignore/gitignore.go

Lines 85 to 87 in f71534c

	if strings.HasPrefix(pattern, "!") {
	return "!" + NormalizeGitignore(pattern[1:])
	}