Fix #57 and #56

Author: Bob Bui

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).  
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## 1.2.7 - 2020-08-27
+ - Fix #57
+
 ## 1.2.6 - 2020-08-05
  - Fix condition for checking root logger handlers #53
 

README.md

@@ -180,7 +180,7 @@ Extra property can be added to logging statement as follow:
 logger.info("test log statement", extra = {'props' : {'extra_property' : 'extra_value'}})
 ```
 ## 2.5 Root logger
-If you want to use root logger as main logger to emit log. Made sure you call **config_root_logger()** after initialize root logger (by logging.basicConfig() or logging.getLogger('root')) [\[2\]](#2-python-logging-propagate)
+If you want to use root logger as main logger to emit log. Made sure you call **config_root_logger()** after initialize root logger (by logging.basicConfig() or logging.getLogger()) [\[2\]](#2-python-logging-propagate)
 ```python
 logging.basicConfig()
 json_logging.init_<framework name >()

json_logging/__init__.py

@@ -78,13 +78,13 @@ def config_root_logger():
         You must call this if you are using root logger.
         Make all root logger' handlers produce JSON format
         & remove duplicate handlers for request instrumentation logging.
-        Please made sure that you call this after you called "logging.basicConfig() or logging.getLogger('root')
+        Please made sure that you call this after you called "logging.basicConfig() or logging.getLogger()
     """
 
     if not logging.root.handlers:
         _logger.error(
             "No logging handlers found for root logger. Please made sure that you call this after you called "
-            "logging.basicConfig() or logging.getLogger('root')")
+            "logging.basicConfig() or logging.getLogger()")
         return
 
     if ENABLE_JSON_LOGGING:
@@ -105,7 +105,7 @@ def __init(framework_name=None, custom_formatter=None, enable_json=False):
 
     If **custom_formatter** is passed, it will (in non-web context) use this formatter over the default.
 
-    :param framework_name: type of framework logging should support.
+    :param framework_name: type of framework logging should support.DEFAULT_CORRELATION_ID_HEADERS
     :param custom_formatter: formatter to override default JSONLogFormatter.
     """
 
@@ -141,7 +141,7 @@ def __init(framework_name=None, custom_formatter=None, enable_json=False):
 
     if not enable_json and not ENABLE_JSON_LOGGING:
         _logger.warning(
-            "JSON format is not enable, normal log will be in plain text but request logging still in JSON format! "
+            "JSON format is not enabled, normal log will be in plain text but request logging still in JSON format! "
             "To enable set ENABLE_JSON_LOGGING env var to either one of following values: ['true', '1', 'y', 'yes']")
     else:
         ENABLE_JSON_LOGGING = True

setup.py

@@ -12,7 +12,7 @@
 
 setup(
     name="json-logging",
-    version='1.2.6',
+    version='1.2.7',
     packages=find_packages(exclude=['contrib', 'docs', 'tests*', 'example', 'dist', 'build']),
     license='Apache License 2.0',
     description="JSON Python Logging",