woff2 fails to compile on GCC 15; vendor the patch?

[Aeledfyr]

woff2 fails to compile on GCC 15 due to a missing include; there's a patch available, but it hasn't been merged upstream: google/woff2#176. It seems like upstream may be unmaintained, since it hasn't had commits in two years?

There's some precedent for applying the patch to the vendored source, from servo: servo/fontsan#37

For reference, this is the error:

warning: woff@0.6.1: In file included from vendor/woff2/source/src/woff2_out.cc:9:
warning: woff@0.6.1: vendor/woff2/source/include/woff2/output.h:73:25: error: expected ')' before '*' token
warning: woff@0.6.1:    73 |   WOFF2MemoryOut(uint8_t* buf, size_t buf_size);
warning: woff@0.6.1:       |                 ~       ^
warning: woff@0.6.1:       |                         )
warning: woff@0.6.1: vendor/woff2/source/include/woff2/output.h:79:3: error: 'uint8_t' does not name a type
warning: woff@0.6.1:    79 |   uint8_t* buf_;
warning: woff@0.6.1:       |   ^~~~~~~
warning: woff@0.6.1: vendor/woff2/source/include/woff2/output.h:16:1: note: 'uint8_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
warning: woff@0.6.1:    15 | #include <string>
warning: woff@0.6.1:   +++ |+#include <cstdint>
warning: woff@0.6.1:    16 | 

[mwcz]

Can confirm, I ran into this too, and the fix suggested in the error message does work.

[paul-hansen]

@bodoni @IvanUkhov I created a PR to apply the vendor patch similar to how Servo does it: #5

Unfortunately that means it isn't a submodule anymore which isn't as nice. I played around with patching it in the build script but it was a bit messy to have to worry about either leaving a dirty git status, or the possible side effects of trying to revert the patch after the build. I could look into this more if desired though.
Another option would be to fork the google/woof repo and point our submodule at our fork, but I'm just a rando so probably not the one you want to own the fork.

I ran into this problem while trying to build the blitz examples, just thought I'd try to help a bit. I'm on arch, I assume more distros will be eventually updating to gcc 15 and this will start affecting more people.

[IvanUkhov]

Thank you for pinging me! Somehow I was not received updates about this repository.

I would prefer to go with the other option (forking and patching):

https://github.com/copies/woff2

I will apply the patch and switch to the above repository.

[paul-hansen]

No worries, I figured it might have been a GitHub company account notification issue. That sounds great, thanks!

[IvanUkhov]

Is anybody able to verify that v0.6.2 compiles on GCC 15?

[paul-hansen]

Works great! Was able to run the blitz examples after a cargo update to pick up the new version. Thanks again!

gcc version 15.2.1 20250813 (GCC)