fix: spinner should only clear multi-line (#374)

Fixes #373

Author: 43081j

.changeset/cruel-hairs-swim.md

@@ -0,0 +1,5 @@
+---
+"@clack/prompts": patch
+---
+
+Fix spinner clearing too many lines upwards when non-wrapping.

packages/prompts/src/spinner.ts

@@ -101,7 +101,9 @@ export const spinner = ({
 			trim: false,
 		});
 		const prevLines = wrapped.split('\n');
-		output.write(cursor.up(prevLines.length - 1));
+		if (prevLines.length > 1) {
+			output.write(cursor.up(prevLines.length - 1));
+		}
 		output.write(cursor.to(0));
 		output.write(erase.down());
 	};

packages/prompts/test/__snapshots__/progress-bar.test.ts.snap

@@ -6,7 +6,6 @@ exports[`prompts - progress (isCI = false) > message > sets message for next fra
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ foo",
@@ -96,15 +95,12 @@ exports[`prompts - progress (isCI = false) > start > renders frames at interval
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◓  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◑  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
@@ -135,7 +131,6 @@ exports[`prompts - progress (isCI = false) > stop > renders cancel symbol if cod
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "■  
@@ -150,7 +145,6 @@ exports[`prompts - progress (isCI = false) > stop > renders error symbol if code
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "▲  
@@ -165,7 +159,6 @@ exports[`prompts - progress (isCI = false) > stop > renders message 1`] = `
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  foo
@@ -180,7 +173,6 @@ exports[`prompts - progress (isCI = false) > stop > renders message without remo
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  foo.
@@ -195,7 +187,6 @@ exports[`prompts - progress (isCI = false) > stop > renders submit symbol and st
   "│
 ",
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -210,19 +201,15 @@ exports[`prompts - progress (isCI = false) > style > renders block progressbar 1
   "│
 ",
   "◒  ██████████ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ██████████ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◓  ██████████ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◑  ██████████ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -237,19 +224,15 @@ exports[`prompts - progress (isCI = false) > style > renders heavy progressbar 1
   "│
 ",
   "◒  ━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◓  ━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◑  ━━━━━━━━━━ ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -264,19 +247,15 @@ exports[`prompts - progress (isCI = false) > style > renders light progressbar 1
   "│
 ",
   "◒  ────────── ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ────────── ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◓  ────────── ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◑  ────────── ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -293,7 +272,6 @@ exports[`prompts - progress (isCI = true) > message > sets message for next fram
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ foo...",
@@ -412,7 +390,6 @@ exports[`prompts - progress (isCI = true) > stop > renders cancel symbol if code
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "■  
@@ -429,7 +406,6 @@ exports[`prompts - progress (isCI = true) > stop > renders error symbol if code
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "▲  
@@ -446,7 +422,6 @@ exports[`prompts - progress (isCI = true) > stop > renders message 1`] = `
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  foo
@@ -463,7 +438,6 @@ exports[`prompts - progress (isCI = true) > stop > renders message without remov
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  foo.
@@ -480,7 +454,6 @@ exports[`prompts - progress (isCI = true) > stop > renders submit symbol and sto
   "◒  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -497,13 +470,11 @@ exports[`prompts - progress (isCI = true) > style > renders block progressbar 1`
   "◒  ██████████ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ██████████ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -520,13 +491,11 @@ exports[`prompts - progress (isCI = true) > style > renders heavy progressbar 1`
   "◒  ━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ━━━━━━━━━━ ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇  
@@ -543,13 +512,11 @@ exports[`prompts - progress (isCI = true) > style > renders light progressbar 1`
   "◒  ────────── ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◐  ────────── ...",
   "
 ",
-  "<cursor.up count=0>",
   "<cursor.left count=1>",
   "<erase.down>",
   "◇