Skip to content

Commit 367bb76

Browse files
committed
Fixing tests for changes in something
Had to up the screen size for the tests. I don't know why it worked until now. Although looking at the browser in non-headless, there was a new box at the top of the page saying the browser was being driven for tests. Maybe that changed the dimensions enough?
1 parent 685dcdd commit 367bb76

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.yarnrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
# yarn lockfile v1
33

44

5-
lastUpdateCheck 1729300363924
5+
lastUpdateCheck 1741566858991

compose.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ services:
2121
command: /bin/bash
2222

2323
selenium:
24-
# Try removing headless=old option when upgrading the version.
25-
image: selenium/standalone-chrome:129.0
24+
image: selenium/standalone-chrome:133.0
25+
shm_size: 2gb
2626
logging:
2727
driver: none
2828
stdin_open: true
@@ -32,3 +32,4 @@ services:
3232
ports:
3333
- '4444:4444'
3434
- '5900:5900'
35+
- '7900:7900'

demo/test/application_system_test_case.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ def remote_selenium? = @remote_selenium ||= ENV["SELENIUM_HOST"].present? || ENV
1818
{}
1919
end
2020

21-
driven_by :selenium, using: :headless_chrome, screen_size: [960, 720], options: options do |capabilities|
21+
# Debugging tip: Change to `chrome` (not headless) and then browse to:
22+
# http://localhost:7900/?autoconnect=1&resize=scale&password=secret. You can watch the fun there.
23+
driven_by :selenium, using: :headless_chrome, screen_size: [960, 800], options: options do |capabilities|
2224
capabilities.add_argument("force-device-scale-factor=1")
2325
capabilities.add_argument("lang=#{ENV.fetch('LANG', 'en_CA')}")
24-
# Needed for Selenium 129. Presumably remove at some point.
25-
capabilities.add_argument("--headless=old")
2626
end
2727

2828
if remote_selenium?

0 commit comments

Comments
 (0)