Skip to content

repository hooks are not applied for all repository actions #63

@goebbe

Description

@goebbe

Testing vykar 0.12.6 on Linux.

When I am not connected to my home Wi-Fi, backups to my home NAS don't make sense.
My NAS repository cannot be reached from outside.

Therefore, I use the following repository hook:

repositories:
  - label: "homeNAS"
    url: "sftp://user@192.168.0.10/backup/vykar_test_repo"
    hooks:
      before: >-
        iwgetid | grep -q 'mySSID'

Expected behaviour:
Before trying to connect the "homeNAS" repository, vykar runs the hook.
If the hook fails (i.e. when I am not connected to my home SSID "mySSID") vykar should never try to connect to the repo.

Observed behaviour:
When I start vykar-gui (not connected to "mySSID", I get two (unexpected) error messages.
Apparently vykar-gui, when started, triea to connect to the repositories, in order to get information about the snapshots in the repository.
Since vykar failed to connect, the errors have been written to the log:

[homeNAS] info failed: SSH connect ... Network is unreachable (os error 101) 
[homeNAS] snapshot listing failed: SSH connect ... Network is unreachable (os error 101) 

Unexpected behaviour (issue):
Given my repository hook, vykar should never try to connect to the server, when not connected to mySSID.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions