Skip to content

Commit b8b8733

Browse files
author
Niklas Kiefer
committed
test(a11y): remove scrollable rule for palette
This is resolved now 🎉
1 parent df6cadd commit b8b8733

File tree

4 files changed

+4
-22
lines changed

4 files changed

+4
-22
lines changed

e2e/visual/no-theme.spec.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,8 @@ test('no-theme - editor', async ({ page, makeAxeBuilder }) => {
7777
await expect(page).toHaveScreenshot();
7878

7979
// and then
80-
// @Note(pinussilvestrus): the palette entries are currently
81-
// not keyboard accessible, as we need to invest in an overall
82-
// editor keyboard experience
83-
// cf. https://github.com/bpmn-io/form-js/issues/536
8480
const results = await makeAxeBuilder({
8581
disableRules: [
86-
'scrollable-region-focusable',
8782
'page-has-heading-one'
8883
]
8984
}).analyze();

e2e/visual/theming.spec.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,8 @@ test('theming - editor', async ({ page, makeAxeBuilder }) => {
7777
await expect(page).toHaveScreenshot();
7878

7979
// and then
80-
// @Note(pinussilvestrus): the palette entries are currently
81-
// not keyboard accessible, as we need to invest in an overall
82-
// editor keyboard experience
83-
// cf. https://github.com/bpmn-io/form-js/issues/536
8480
const results = await makeAxeBuilder({
8581
disableRules: [
86-
'scrollable-region-focusable',
8782
'page-has-heading-one'
8883
]
8984
}).analyze();

packages/form-js-editor/assets/form-js-editor-base.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
--cds-border-strong,
6262
var(--cds-border-strong-01, var(--color-grey-225-10-80))
6363
);
64-
--color-palette-field-focus: var(--cds-border-interactive, var(--color-blue-219-100-53));
64+
--color-palette-field-focus: var(--cds-border-interactive, var(--color-blue-205-100-40));
6565
--color-palette-field-hover-background: var(--cds-background-hover, var(--color-grey-225-10-90));
6666
--cursor-palette-field: grab;
6767
--palette-width: 250px;
@@ -628,6 +628,7 @@
628628
font-size: 11px;
629629
align-items: center;
630630
border: none;
631+
font-family: inherit;
631632
user-select: none;
632633
color: var( --color-palette-field);
633634
background: var(--color-palette-field-background);
@@ -648,6 +649,7 @@
648649

649650
.fjs-palette-field .fjs-palette-field-text {
650651
text-align: center;
652+
width: inherit;
651653
}
652654

653655
.fjs-palette-container .fjs-palette-field:hover {

packages/form-js-editor/test/spec/FormEditor.spec.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1501,17 +1501,7 @@ describe('FormEditor', function() {
15011501
});
15021502

15031503
// then
1504-
// @Note(pinussilvestrus): the palette entries are currently
1505-
// not keyboard accessible, as we need to invest in an overall
1506-
// editor keyboard experience
1507-
// cf. https://github.com/bpmn-io/form-js/issues/536
1508-
await expectNoViolations(container, {
1509-
rules: {
1510-
'scrollable-region-focusable': {
1511-
enabled: false
1512-
}
1513-
}
1514-
});
1504+
await expectNoViolations(container);
15151505
});
15161506

15171507
});

0 commit comments

Comments
 (0)