Default behaviour should search up to root

[jayvdb]

IMO the find_file parameter under should be optional. i.e. the default behaviour should not require a limit. Constructing the limit means the caller needs to stray into OS specific logic, which overly complicates what should be the default behaviour.

[bpshaver]

In principle I agree with you, and if Rust supported default parameters values I probably would have made / the default.

Also in principle, how would you suggest making that change without breaking backwards compatibility?

Otherwise I would propose a separate function adapting find_file for the case without a limit, the way I did with home_find_file. The library is obviously small enough it would be easily found by anyone looking for it.

Note: I think the reason I did not include this originally was because I conceived this library being used to find user-specific config and dot files that would tend to be stored under the user's home directory somewhere.

[jayvdb]

I'm happy to add a new function.
find_file_up ?

[bpshaver]

I like find_file_root. I may independently deprecate home_find_file because I like find_file_home more.

I'm using the dirs crate to access different directories in a cross platform way, but I don't see a cross-platform way to identify the root directory there, presumably because on Windows that could be C:\ or something else. I'm not comfortable with using something like PathBuf::from(r"/"). If it isn't easy to find the root, I'd prefer just to force users to do it themselves if for some reason they want to search up above the home directory.