From 8dc2c52ae77be27488cb6bb37271d831d83fdc0c Mon Sep 17 00:00:00 2001 From: Liz Baldo Date: Tue, 25 Nov 2025 10:14:18 -0500 Subject: [PATCH 1/5] migrate job key value entry id from int to bigint --- .../src/main/resources/changelog.xml | 1 + .../enlarge_job_key_value_entry_id.xml | 50 +++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml diff --git a/database/migration/src/main/resources/changelog.xml b/database/migration/src/main/resources/changelog.xml index 81036465176..6e6887f003f 100644 --- a/database/migration/src/main/resources/changelog.xml +++ b/database/migration/src/main/resources/changelog.xml @@ -93,6 +93,7 @@ + + + + + + + + + + + + + + + + + + + SELECT count(*) + FROM information_schema.sequences + WHERE sequence_name = 'JOB_KEY_VALUE_ENTRY_JOB_KEY_VALUE_ENTRY_ID_seq' + AND data_type = 'bigint'; + + + ALTER SEQUENCE "JOB_KEY_VALUE_ENTRY_JOB_KEY_VALUE_ENTRY_ID_seq" as bigint RESTART WITH 20000000000; + + + + From 85c6f6f16fd8d0609fca323b097a31dae2f40060 Mon Sep 17 00:00:00 2001 From: Liz Baldo Date: Tue, 25 Nov 2025 12:39:15 -0500 Subject: [PATCH 2/5] simplify migration --- .../changesets/enlarge_job_key_value_entry_id.xml | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml b/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml index 306d660299e..3a3480b3a32 100644 --- a/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml +++ b/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml @@ -7,20 +7,11 @@ - - - - - + @@ -33,7 +24,7 @@ /> - + @@ -43,7 +34,7 @@ AND data_type = 'bigint'; - ALTER SEQUENCE "JOB_KEY_VALUE_ENTRY_JOB_KEY_VALUE_ENTRY_ID_seq" as bigint RESTART WITH 20000000000; + alter sequence "JOB_KEY_VALUE_ENTRY_JOB_KEY_VALUE_ENTRY_ID_seq" as bigint; From 440884f2c101aeb0a6ceafa5fbdfeb4bd1527676 Mon Sep 17 00:00:00 2001 From: Liz Baldo Date: Tue, 25 Nov 2025 12:44:55 -0500 Subject: [PATCH 3/5] add changelog and corresponding Scala type change --- CHANGELOG.md | 3 +++ .../database/slick/tables/JobKeyValueEntryComponent.scala | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 249775fb311..5462b36003a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## 92 Release Notes +### Migration of PK to BIGINT +The PK of the JOB_KEY_VALUE_ENTRY table will be migrated from INT to BIGINT. + ### AWS Batch * Moved the option to tag job resources from runtime attributes to backend config. * Appended the custom labels to the list of resource tags to propagate diff --git a/database/sql/src/main/scala/cromwell/database/slick/tables/JobKeyValueEntryComponent.scala b/database/sql/src/main/scala/cromwell/database/slick/tables/JobKeyValueEntryComponent.scala index cd730a5c154..82889fc3c3a 100644 --- a/database/sql/src/main/scala/cromwell/database/slick/tables/JobKeyValueEntryComponent.scala +++ b/database/sql/src/main/scala/cromwell/database/slick/tables/JobKeyValueEntryComponent.scala @@ -9,7 +9,7 @@ trait JobKeyValueEntryComponent { import driver.api._ class JobKeyValueEntries(tag: Tag) extends Table[JobKeyValueEntry](tag, "JOB_KEY_VALUE_ENTRY") { - def jobKeyValueEntryId = column[Int]("JOB_KEY_VALUE_ENTRY_ID", O.PrimaryKey, O.AutoInc) + def jobKeyValueEntryId = column[Long]("JOB_KEY_VALUE_ENTRY_ID", O.PrimaryKey, O.AutoInc) def workflowExecutionUuid = column[String]("WORKFLOW_EXECUTION_UUID", O.Length(255)) From c4d32575fba8e983474410d4ca5b294bc375e867 Mon Sep 17 00:00:00 2001 From: Liz Baldo Date: Tue, 25 Nov 2025 15:13:24 -0500 Subject: [PATCH 4/5] one more scala type fix --- .../scala/cromwell/database/sql/tables/JobKeyValueEntry.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/database/sql/src/main/scala/cromwell/database/sql/tables/JobKeyValueEntry.scala b/database/sql/src/main/scala/cromwell/database/sql/tables/JobKeyValueEntry.scala index 8b768ff66de..a517dccbe6f 100644 --- a/database/sql/src/main/scala/cromwell/database/sql/tables/JobKeyValueEntry.scala +++ b/database/sql/src/main/scala/cromwell/database/sql/tables/JobKeyValueEntry.scala @@ -7,5 +7,5 @@ case class JobKeyValueEntry( jobAttempt: Int, storeKey: String, storeValue: String, - jobKeyValueEntryId: Option[Int] = None + jobKeyValueEntryId: Option[Long] = None ) From 4fe3f66426abfdffcd5b195fc99a17953ba79387 Mon Sep 17 00:00:00 2001 From: Liz Baldo Date: Tue, 2 Dec 2025 09:17:12 -0500 Subject: [PATCH 5/5] fix comment --- .../resources/changesets/enlarge_job_key_value_entry_id.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml b/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml index 3a3480b3a32..b9d1c51da8a 100644 --- a/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml +++ b/database/migration/src/main/resources/changesets/enlarge_job_key_value_entry_id.xml @@ -5,8 +5,8 @@ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.3.xsd"> - +