-
Notifications
You must be signed in to change notification settings - Fork 4
Warning: "'Call' is deprecated" when building with Node 10 #23
Copy link
Copy link
Open
Description
There are several warnings about deprecated methods when you attempt to install this loader in a Node 10 environment.
Full output:
> node-gyp rebuild
TOUCH Release/obj.target/libvips-cpp.stamp
CXX(target) Release/obj.target/sharp/src/common.o
CXX(target) Release/obj.target/sharp/src/metadata.o
../src/metadata.cc:136:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
callback->Call(2, argv);
^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Local<v8::Value>
^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
^
1 warning generated.
CXX(target) Release/obj.target/sharp/src/operations.o
CXX(target) Release/obj.target/sharp/src/pipeline.o
../src/pipeline.cc:976:8: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
[this](sharp::InputDescriptor *joinChannelIn) {
^
../src/pipeline.cc:984:20: warning: 'Call' is deprecated [-Wdeprecated-declarations]
queueListener->Call(1, queueLength);
^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Local<v8::Value>
^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
^
../src/pipeline.cc:988:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
callback->Call(3, argv);
^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Local<v8::Value>
^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
^
../src/pipeline.cc:1250:18: warning: 'Call' is deprecated [-Wdeprecated-declarations]
queueListener->Call(1, queueLength);
^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Local<v8::Value>
^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
^
4 warnings generated.
CXX(target) Release/obj.target/sharp/src/sharp.o
CXX(target) Release/obj.target/sharp/src/utilities.o
SOLINK_MODULE(target) Release/sharp.node
TOUCH Release/obj.target/win_copy_dlls.stamp
Everything still appears to work just fine, but Node 10 might be the last supported version until an update arrives.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels