review changes

Author: rev-doshi

bin/accessibility-automation/cypress/index.js

@@ -53,7 +53,7 @@ Cypress.on('test:after:run', (attributes, runnable) => {
         os_data = Cypress.platform === 'linux' ? 'mac' : "win"
       }
       let filePath = '';
-      if (attributes.invocationDetails.relativeFile !== undefined) {
+      if (attributes.invocationDetails !== undefined && attributes.invocationDetails.relativeFile !== undefined) {
         filePath = attributes.invocationDetails.relativeFile;
       }
       const dataForExtension = {

bin/accessibility-automation/helper.js

@@ -14,7 +14,6 @@ exports.checkAccessibilityPlatform = (user_config) => {
     user_config.browsers.forEach(browser => {
       if (browser.accessibility) {
         accessibility = true;
-        return true;
       }
     })
   } catch {}
@@ -82,9 +81,10 @@ exports.createAccessibilityTestRun = async (user_config, framework) => {
     const response = await nodeRequest(
       'POST', 'test_runs', data, config, API_URL
     );
-    process.env.BS_A11Y_JWT = response?.data?.data?.accessibilityToken;
-    process.env.BS_A11Y_TEST_RUN_ID = response?.data?.data?.id;
-
+    if(!utils.isUndefined(response.data)) {
+      process.env.BS_A11Y_JWT = response.data.data.accessibilityToken;
+      process.env.BS_A11Y_TEST_RUN_ID = response.data.data.id;
+    }
     if (process.env.BS_A11Y_JWT) {
       process.env.BROWSERSTACK_TEST_ACCESSIBILITY = 'true';
     }

bin/helpers/capabilityHelper.js

@@ -150,7 +150,7 @@ const getAccessibilityPlatforms = (bsConfig) => {
   const browserList = bsConfig.browsers;
   const accessibilityPlatforms = Array(browserList.length).fill(false);
   let rootLevelAccessibility = false;
-  if (bsConfig.run_settings.accessibility !== undefined) {
+  if (!Utils.isUndefined(bsConfig.run_settings.accessibility)) {
     rootLevelAccessibility = bsConfig.run_settings.accessibility.toString() === 'true'
   }
   browserList.forEach((browserDetails, idx) => {

bin/helpers/helper.js

@@ -1,3 +1,4 @@
+/* Helper methods used by Accessibility and Observability */
 
 const logger = require("../helpers/logger").winstonLogger;
 const utils = require('../helpers/utils');
@@ -6,7 +7,7 @@ const path = require('path');
 const http = require('http');
 const https = require('https');
 const request = require('request');
-var gitLastCommit = require('git-last-commit');
+const gitLastCommit = require('git-last-commit');
 const { v4: uuidv4 } = require('uuid');
 const os = require('os');
 const { promisify } = require('util');

bin/helpers/utils.js

@@ -559,7 +559,7 @@ exports.setSystemEnvs = (bsConfig) => {
   }
 
   try {
-    const accessibilityOptions = bsConfig.run_settings?.accessibilityOptions;
+    const accessibilityOptions = bsConfig.run_settings.accessibilityOptions;
     if (accessibilityOptions) {
       Object.keys(accessibilityOptions).forEach(key => {
         const a11y_env_key = `ACCESSIBILITY_${key.toUpperCase()}`

bin/testObservability/helper/helper.js

@@ -3,11 +3,9 @@ const path = require('path');
 const http = require('http');
 const https = require('https');
 const request = require('request');
-var gitLastCommit = require('git-last-commit');
 const { v4: uuidv4 } = require('uuid');
 const os = require('os');
 const { promisify } = require('util');
-const getRepoInfo = require('git-repo-info');
 const gitconfig = require('gitconfiglocal');
 const { spawn, execSync } = require('child_process');
 const glob = require('glob');