refactor: Resolve review comments

Author: sauravdas1997

bin/testObservability/helper/helper.js

@@ -163,24 +163,19 @@ exports.getTestEnv = () => {
 }
 
 exports.getFileSeparatorData = () => {
-  const fileSeparatorRegex = /^win/.test(process.platform) ? "\\" : "/";
-  const fileSeparator = /^win/.test(process.platform) ? "\\" : "/";
-  return {
-    fileSeparator,
-    fileSeparatorRegex
-  };
+  return /^win/.test(process.platform) ? "\\" : "/";
 }
 
 exports.findGitConfig = (filePath) => {
-  const { fileSeparator, fileSeparatorRegex } = exports.getFileSeparatorData();
+  const fileSeparator = exports.getFileSeparatorData();
   if(filePath == null || filePath == '' || filePath == fileSeparator) {
     return null;
   }
   try {
     fs.statSync(filePath + fileSeparator + '.git' + fileSeparator + 'config');
     return filePath;
   } catch(e) {
-    let parentFilePath = filePath.split(fileSeparatorRegex);
+    let parentFilePath = filePath.split(fileSeparator);
     parentFilePath.pop();
     return exports.findGitConfig(parentFilePath.join(fileSeparator));
   }

bin/testObservability/reporter/index.js

@@ -284,7 +284,7 @@ class MyReporter {
       if(!isBrowserstackInfra()) gitConfigPath = process.env.OBSERVABILITY_GIT_CONFIG_PATH_LOCAL ? process.env.OBSERVABILITY_GIT_CONFIG_PATH_LOCAL.toString() : null;
       const prefixedTestPath = rootParentFile ? this._paths.prefixTestPath(rootParentFile) : 'File path could not be found';
 
-      const { fileSeparator, fileSeparatorRegex } = getFileSeparatorData();
+      const fileSeparator = getFileSeparatorData();
 
       let testData = {
         'framework': 'Cypress',