zip deletion metric fix

Author: Raghav11-11

bin/commands/runs.js

@@ -468,8 +468,8 @@ module.exports = function run(args, rawArgs) {
                 utils.sendUsageReport(bsConfig, args, `${err}\n${Constants.userMessages.LOCAL_START_FAILED}`, Constants.messageTypes.ERROR, 'local_start_failed', buildReportData, rawArgs);
               } else {
                 logger.error(Constants.userMessages.ZIP_UPLOAD_FAILED);
-                fileHelpers.deleteZip();
                 utils.sendUsageReport(bsConfig, args, `${err}\n${Constants.userMessages.ZIP_UPLOAD_FAILED}`, Constants.messageTypes.ERROR, 'zip_upload_failed', buildReportData, rawArgs);
+                fileHelpers.deleteZip();
                 try {
                   fileHelpers.deletePackageArchieve();
                 } catch (err) {

bin/helpers/fileHelpers.js

@@ -32,7 +32,7 @@ exports.deleteZip = () => {
     return 0;
   } catch (err) {
     logger.info(Constants.userMessages.ZIP_DELETE_FAILED);
-    return 1;
+    throw err;
   }
 };