fix zip upload log

Author: Sourav

bin/helpers/zipUpload.js

@@ -52,35 +52,33 @@ const uploadSuits = (bsConfig, filePath, opts, obj) => {
     var r = request.post(options, function (err, resp, body) {
 
       if (err) {
-        logger.error(utils.formatRequest(err, resp, body));
-        reject(err);
+        reject({message: err, stacktrace: utils.formatRequest(err, resp, body)});
       } else {
         try {
           responseData = JSON.parse(body);
         } catch (e) {
           responseData = {};
         }
         if (resp.statusCode != 200) {
-          logger.error(utils.formatRequest(err, resp, body));
           if (resp.statusCode == 401) {
             if (responseData && responseData["error"]) {
               responseData["time"] = Date.now() - obj.startTime;
-              return reject(responseData["error"]);
+              return reject({message: responseData["error"], stacktrace: utils.formatRequest(err, resp, body)});
             } else {
-              return reject(Constants.validationMessages.INVALID_DEFAULT_AUTH_PARAMS);
+              return reject({message: Constants.validationMessages.INVALID_DEFAULT_AUTH_PARAMS, stacktrace: utils.formatRequest(err, resp, body)});
             } 
           }
           if (!opts.propogateError){
             return resolve({});
           }
           if(responseData && responseData["error"]){
             responseData["time"] = Date.now() - obj.startTime;
-            reject(responseData["error"]);
+            reject({message: responseData["error"], stacktrace: utils.formatRequest(err, resp, body)});
           } else {
             if (resp.statusCode == 413) {
-              reject(Constants.userMessages.ZIP_UPLOAD_LIMIT_EXCEEDED);
+              reject({message: Constants.userMessages.ZIP_UPLOAD_LIMIT_EXCEEDED, stacktrace: utils.formatRequest(err, resp, body)});
             } else {
-              reject(Constants.userMessages.ZIP_UPLOADER_NOT_REACHABLE);
+              reject({message: Constants.userMessages.ZIP_UPLOADER_NOT_REACHABLE, stacktrace: utils.formatRequest(err, resp, body)});
             }
           }
         } else {
@@ -151,7 +149,8 @@ const uploadCypressZip = (bsConfig, md5data, packageData) => {
     }).catch((error) => {
       testZipUploadObj.bar1 && purgeUploadBar(testZipUploadObj);
       npmPackageZipUploadObj.bar1 && purgeUploadBar(npmPackageZipUploadObj);
-      return reject(error);
+      logger.error(error.stacktrace)
+      return reject(error.message);
     })
   })
 }

test/unit/bin/helpers/zipUpload.js

@@ -85,7 +85,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.equal(error.message, "test error");
+          chai.assert.equal(error.message.message, "test error");
         });
     });
 
@@ -219,7 +219,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.equal(error, "auth failed");
+          chai.assert.equal(error.message, "auth failed");
         });
     });
 
@@ -249,7 +249,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.equal(error, constant.validationMessages.INVALID_DEFAULT_AUTH_PARAMS);
+          chai.assert.equal(error.message, constant.validationMessages.INVALID_DEFAULT_AUTH_PARAMS);
         });
     });
 
@@ -311,7 +311,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.deepEqual(error, "test error");
+          chai.assert.deepEqual(error.message, "test error");
         });
     });
 
@@ -342,7 +342,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.deepEqual(error, constant.userMessages.ZIP_UPLOAD_LIMIT_EXCEEDED);
+          chai.assert.deepEqual(error.message, constant.userMessages.ZIP_UPLOAD_LIMIT_EXCEEDED);
         });
     });
 
@@ -373,7 +373,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.deepEqual(error, constant.userMessages.ZIP_UPLOADER_NOT_REACHABLE);
+          chai.assert.deepEqual(error.message, constant.userMessages.ZIP_UPLOADER_NOT_REACHABLE);
         });
     });
   });
@@ -427,7 +427,7 @@ describe("zipUpload", () => {
           chai.assert.fail("Promise error");
         })
         .catch((error) => {
-          chai.assert.equal(error, "test error");
+          chai.assert.equal(error.message, "test error");
       });
     });
   });