-
Notifications
You must be signed in to change notification settings - Fork 4
Support for private registries #172
Copy link
Copy link
Open
Labels
P3 - normalNew features, bugs with workarounds, bugs affecting very specific usage...New features, bugs with workarounds, bugs affecting very specific usage...crt:sampo-coreChanges in Sampo core logic or internal utils.Changes in Sampo core logic or internal utils.
Metadata
Metadata
Assignees
Labels
P3 - normalNew features, bugs with workarounds, bugs affecting very specific usage...New features, bugs with workarounds, bugs affecting very specific usage...crt:sampo-coreChanges in Sampo core logic or internal utils.Changes in Sampo core logic or internal utils.
Hi @goulvenclech ,
I wanted to ask whether you plan to add support for private registries in the mid- or long-term?
Currently the check whether a crate is already published seems to be hardcoded to crates.io.
sampo/crates/sampo-core/src/adapters/cargo.rs
Lines 273 to 275 in 1dcc188
(In theory, one can use
cargo_utilsto resolve registry urls + authentication tokens. as I did here: crate-ci/cargo-release#927. AFAIKcargo-editalso has the ability to resolve registry URLs, but not tokens. However, to solve it properly (with credential providers etc), we would probably have to duplicate a lot of code from cargo.)Note: We're still not using sampo actively (instead still evaluating, stuck with other work), so no need to get active right now.
Also, I recall you mentioned me to try a new feature recently. but i cant find the comment anymore..? Would you be kind enough to send it to me again? Thank you