remove check that forbids using the templateFileLocation generate option if a default buf.gen.yaml exists in the project directory#435
Open
masariello wants to merge 1 commit intobufbuild:mainfrom
Conversation
…ion if a default buf.gen.yaml exists
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to allow consumer projects to keep a default
bug.gen.yamlin the project directory along side secondary ones that are passed to the plugin via thetemplateFileLocationgenerate optionAt the moment the above is not possible. Consumer projects have to delete
bug.gen.ymlto avoid the error when they want to generate with a template that uses a different nameUse case: project wants to use
buf.gen.yamlfor public builds, and wants to keep a separatebuf.private.gen.yamlto build a wider set of proto module directories