Merge pull request #2438 from buildkite/fix-h1-search

Add ids to h1 tags for search

Author: dannymidnight

app/models/page/renderer.rb

@@ -75,6 +75,14 @@ def add_automatic_ids_to_headings(doc)
     h2_ids = []
     h3s_with_manual_ids = []
 
+    # h1 headers
+    doc.search('./h1').each do |header|
+      if (id = header['id']).blank?
+        id = header['id'] = header.text.to_url
+      end
+    end
+
+    # h2 headers
     doc.search('./h2').each do |h2|
       if (id = h2['id']).blank?
         id = h2['id'] = h2.text.to_url

spec/models/page/renderer_spec.rb

@@ -8,7 +8,7 @@
     MD
 
     html = <<~HTML
-      <h1>Page title</h1>
+      <h1 id="page-title">Page title</h1>
 
       <p>Some description</p>
     HTML