feat: optimized args

Author: bvanjoi

.eslintrc.yml

@@ -7,6 +7,8 @@ env:
   push:
     branches:
       - main
+    paths:
+      - 'package.json'
 
 jobs:
   build:

.github/workflows/Publish.yml

@@ -45,6 +45,7 @@ build/Release
 # Dependency directories
 node_modules/
 jspm_packages/
+!__test__/
 
 # TypeScript v1 declaration files
 typings/

.github/workflows/lint.yml

@@ -2,11 +2,37 @@ import path from 'path'
 
 import test from 'ava'
 
-import factory from '../index'
+import factory, { RawResolverOptions } from '../index'
 
 test('sync function from native code', (t) => {
-  const resolver = factory.create(JSON.stringify({}))
-  const result = factory.resolve(resolver, __dirname, './lib.js')
-  t.is(result.path, path.resolve(__dirname, './lib.js'))
+  const resolver = factory.create({})
+  const result = factory.resolve(resolver, __dirname, './fixture/lib')
+  t.is(result.path, path.resolve(__dirname, './fixture/lib.js'))
+  t.is(result.status, true)
+})
+
+test('resolve do not exist file', (t) => {
+  const resolver = factory.create({})
+  let count = 0
+  let encounterError = false
+  try {
+    count += 1
+    factory.resolve(resolver, __dirname, './lib')
+    count += 1
+  } catch (err: any) {
+    encounterError = true
+    t.assert((err.message as string).includes('Resolve ./lib failed in'))
+  }
+  t.is(count, 1)
+  t.is(encounterError, true)
+})
+
+test('extensions options', (t) => {
+  const resolverOptions: RawResolverOptions = {
+    extensions: ['ts', 'js'],
+  }
+  const resolver = factory.create(resolverOptions)
+  const result = factory.resolve(resolver, __dirname, './fixture/lib')
+  t.is(result.path, path.resolve(__dirname, './fixture/lib.ts'))
   t.is(result.status, true)
 })

.gitignore

@@ -9,12 +9,28 @@ export class ExternalObject<T> {
     [K: symbol]: T
   }
 }
-export interface ResolverInternal {
-  
+export interface RawResolverOptions {
+  extensions?: Array<string>
+  enforceExtension?: boolean | undefined | null
+  alias?: Record<string, string | undefined | null>
+  aliasFields?: Array<string>
+  conditionNames?: Array<string>
+  symlinks?: boolean
+  descriptionFile?: string | undefined | null
+  mainFiles?: Array<string>
+  mainFields?: Array<string>
+  modules?: Array<string>
+  preferRelative?: boolean
+  enableUnsafeCache?: boolean
 }
-export function create(options: string): ExternalObject<ResolverInternal>
+export interface ResolverInternal {}
+export function create(options: RawResolverOptions): ExternalObject<ResolverInternal>
 export interface ResolveResult {
   status: boolean
   path?: string
 }
-export function resolve(resolver: ExternalObject<ResolverInternal>,): ResolveResult
+export function resolve(
+  resolver: ExternalObject<ResolverInternal>,
+  base_dir: string,
+  id: string,
+): { status: boolean; path?: string }

__test__/lib.js __test__/fixture/lib.js__test__/lib.js renamed to __test__/fixture/lib.js

@@ -1,7 +1,7 @@
 {
   "name": "nodejs-resolver",
-  "version": "0.0.2",
-  "description": "Template project for writing node package with napi-rs",
+  "version": "0.0.3",
+  "description": "node binding for nodejs-resolver",
   "main": "index.js",
   "license": "MIT",
   "keywords": [
@@ -45,33 +45,24 @@
     "format": "run-p format:prettier format:rs",
     "format:prettier": "prettier . -w",
     "format:rs": "cargo fmt",
-    "lint": "eslint . -c ./.eslintrc.yml",
     "prepublishOnly": "napi prepublish -t npm",
     "test": "ava",
     "version": "napi version"
   },
   "devDependencies": {
     "@napi-rs/cli": "^2.7.0",
     "@swc-node/register": "^1.5.1",
-    "@typescript-eslint/eslint-plugin": "^5.22.0",
-    "@typescript-eslint/parser": "^5.22.0",
     "ava": "^4.2.0",
     "benny": "^3.7.1",
     "chalk": "^5.0.1",
-    "eslint": "^8.14.0",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-prettier": "^4.0.0",
     "husky": "^7.0.4",
     "lint-staged": "^12.4.1",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.6.2",
-    "typescript": "^4.6.4"
+    "typescript": "^4.6.4",
+    "@types/node": "^12.12.5"
   },
   "lint-staged": {
-    "*.@(js|ts|tsx)": [
-      "eslint -c .eslintrc.yml --fix"
-    ],
     "*.@(js|ts|tsx|yml|yaml|md|json)": [
       "prettier --write"
     ]