fix: handle unregistered actions and retried actions

Author: narangmayank

src/BytebeamArduino.cpp

@@ -1012,6 +1012,17 @@ bool BytebeamArduino::handleActions(char* actionReceivedStr) {
   BytebeamLogger::Debug(__FILE__, __func__, "payloadStr : %s", payloadStr);
 #endif
 
+  int32_t actionIdVal = (int32_t)(atoi(idStr));
+  int32_t lastKnownActionIdVal = (int32_t)(atoi(this->lastKnownActionId));
+
+  BytebeamLogger::Debug(__FILE__, __func__, "actionIdVal : %ld, lastKnownActionIdVal : %ld\n",actionIdVal, lastKnownActionIdVal);
+
+  // just ignore the previous actions if triggered again
+  if (actionIdVal <= lastKnownActionIdVal) {
+      BytebeamLogger::Error(__FILE__, __func__, "Ignoring %s Action", name);
+      return true;
+  }
+
   int actionIterator = 0;
   while(this->actionFuncs[actionIterator].name) {
     if (!strcmp(this->actionFuncs[actionIterator].name, name)) {
@@ -1022,9 +1033,15 @@ bool BytebeamArduino::handleActions(char* actionReceivedStr) {
   }
 
   if(this->actionFuncs[actionIterator].name == NULL) {
-    BytebeamLogger::Error(__FILE__, __func__, "invalid action : %s", name);
+    BytebeamLogger::Error(__FILE__, __func__, "Invalid Action : %s", name);
+
+    // publish action failed response indicating unregistered action
+    publishActionFailed(idStr, "Unregistered Action");
   }
 
+  // update the last known action id
+  strcpy(this->lastKnownActionId, idStr);
+
   // release the allocated memory :)
   free(idStr);
   free(payloadStr);

src/BytebeamArduino.h

@@ -21,6 +21,9 @@
 /* This macro is used to specify the maximum length of bytebeam mqtt topic string */
 #define BYTEBEAM_MQTT_TOPIC_STR_LEN 200
 
+/* This macro is used to specify the maximum length of bytebeam action id string */
+#define BYTEBEAM_ACTION_ID_STR_LEN 20
+
 /* This macro is used to specify the maximum number of actions that need to be handled for particular device */
 #define BYTEBEAM_NUMBER_OF_ACTIONS 10
 
@@ -160,6 +163,7 @@ class BytebeamArduino : private PubSubClient,
     char* deviceConfigStr;
     bool isClientActive;
     bool isOTAEnable;
+    char lastKnownActionId[BYTEBEAM_ACTION_ID_STR_LEN];
 
     #ifdef BYTEBEAM_ARDUINO_ARCH_ESP32
         #ifdef BYTEBEAM_ARDUINO_USE_WIFI