From 55b3f3af3f0b3c6dbd8b8e96a52b9b717543a85d Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Mon, 13 Apr 2026 05:20:56 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Batch=20@Published=20array?=
 =?UTF-8?q?=20mutations=20to=20reduce=20UI=20recalculations?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
---
 .jules/bolt.md                                |  3 ++
 .../ViewModels/CacheoutViewModel.swift        | 39 +++++++++++++++----
 2 files changed, 34 insertions(+), 8 deletions(-)
 create mode 100644 .jules/bolt.md

diff --git a/.jules/bolt.md b/.jules/bolt.md
new file mode 100644
index 0000000..00095c9
--- /dev/null
+++ b/.jules/bolt.md
@@ -0,0 +1,3 @@
+## 2024-05-13 - Batching @Published Array Mutations
+**Learning:** In SwiftUI ObservableObject view models, mutating individual elements of a @Published array property inside a loop triggers a UI update notification for every change. For collections of value types (structs), functional methods like map batch updates into a single property assignment, significantly reducing unnecessary UI recalculations.
+**Action:** Replace for loop mutations on @Published array collections with .map re-assignments to batch updates, and document this with comments to prevent future reversions.
diff --git a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift
index 13a9811..0ca4549 100644
--- a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift
+++ b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift
@@ -172,14 +172,22 @@ class CacheoutViewModel: ObservableObject {
     }
 
     func selectAllSafe() {
-        for i in scanResults.indices where scanResults[i].category.riskLevel == .safe && !scanResults[i].isEmpty {
-            scanResults[i].isSelected = true
+        // Optimized: Use .map to batch updates into a single @Published assignment, avoiding O(N) UI recalculations
+        scanResults = scanResults.map { result in
+            var modified = result
+            if modified.category.riskLevel == .safe && !modified.isEmpty {
+                modified.isSelected = true
+            }
+            return modified
         }
     }
 
     func deselectAll() {
-        for i in scanResults.indices {
-            scanResults[i].isSelected = false
+        // Optimized: Use .map to batch updates into a single @Published assignment, avoiding O(N) UI recalculations
+        scanResults = scanResults.map { result in
+            var modified = result
+            modified.isSelected = false
+            return modified
         }
         deselectAllNodeModules()
     }
@@ -193,17 +201,32 @@ class CacheoutViewModel: ObservableObject {
     }
 
     func selectStaleNodeModules() {
-        for i in nodeModulesItems.indices where nodeModulesItems[i].isStale {
-            nodeModulesItems[i].isSelected = true
+        // Optimized: Use .map to batch updates into a single @Published assignment, avoiding O(N) UI recalculations
+        nodeModulesItems = nodeModulesItems.map { item in
+            var modified = item
+            if modified.isStale {
+                modified.isSelected = true
+            }
+            return modified
         }
     }
 
     func selectAllNodeModules() {
-        for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = true }
+        // Optimized: Use .map to batch updates into a single @Published assignment, avoiding O(N) UI recalculations
+        nodeModulesItems = nodeModulesItems.map { item in
+            var modified = item
+            modified.isSelected = true
+            return modified
+        }
     }
 
     func deselectAllNodeModules() {
-        for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = false }
+        // Optimized: Use .map to batch updates into a single @Published assignment, avoiding O(N) UI recalculations
+        nodeModulesItems = nodeModulesItems.map { item in
+            var modified = item
+            modified.isSelected = false
+            return modified
+        }
     }
 
     /// Menu bar label: show free GB in the tray