diff --git a/.jules/bolt.md b/.jules/bolt.md new file mode 100644 index 0000000..1486dc0 --- /dev/null +++ b/.jules/bolt.md @@ -0,0 +1,3 @@ +## 2024-05-23 - Batch UI Updates for Published Arrays +**Learning:** Mutating individual elements of a @Published array inside a loop triggers a UI update for every change, leading to O(N) re-renders. +**Action:** For collections of value types, use functional methods like .map to batch updates into a single property assignment, significantly reducing unnecessary UI recalculations. diff --git a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift index 13a9811..822e517 100644 --- a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift +++ b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift @@ -172,14 +172,22 @@ class CacheoutViewModel: ObservableObject { } func selectAllSafe() { - for i in scanResults.indices where scanResults[i].category.riskLevel == .safe && !scanResults[i].isEmpty { - scanResults[i].isSelected = true + // Optimization: Use .map to batch updates and prevent O(N) re-renders + scanResults = scanResults.map { result in + var modified = result + if result.category.riskLevel == .safe && !result.isEmpty { + modified.isSelected = true + } + return modified } } func deselectAll() { - for i in scanResults.indices { - scanResults[i].isSelected = false + // Optimization: Use .map to batch updates and prevent O(N) re-renders + scanResults = scanResults.map { result in + var modified = result + modified.isSelected = false + return modified } deselectAllNodeModules() } @@ -193,17 +201,32 @@ class CacheoutViewModel: ObservableObject { } func selectStaleNodeModules() { - for i in nodeModulesItems.indices where nodeModulesItems[i].isStale { - nodeModulesItems[i].isSelected = true + // Optimization: Use .map to batch updates and prevent O(N) re-renders + nodeModulesItems = nodeModulesItems.map { item in + var modified = item + if item.isStale { + modified.isSelected = true + } + return modified } } func selectAllNodeModules() { - for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = true } + // Optimization: Use .map to batch updates and prevent O(N) re-renders + nodeModulesItems = nodeModulesItems.map { item in + var modified = item + modified.isSelected = true + return modified + } } func deselectAllNodeModules() { - for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = false } + // Optimization: Use .map to batch updates and prevent O(N) re-renders + nodeModulesItems = nodeModulesItems.map { item in + var modified = item + modified.isSelected = false + return modified + } } /// Menu bar label: show free GB in the tray